301353 - Components.utils.evalInSandbox does not report errors

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P1)

Description

[Brendan Eich [:brendan]]

Even though it tries using the calling context's error reporter, the DOM's
NS_ScriptErrorReporter will fail and bail out early for want of an nsJSContext
private data record for the cx -- see the XXX comment at the top.

This should be easy to fix.  Patch in a bit.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

I fixed another bug: the gratuitous GC from JS_DestroyContext after each and
every evalInSandbox, which was bloating up compile time horribly.

/be

Comment 2

[Brendan Eich [:brendan]]

This may matter a lot to GreaseMonkey.

/be

Comment 3

[Brendan Eich [:brendan]]

dbradley, feel free to r+ if you are around.

/be

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 189848 [details] [diff] [review]
proposed fix

Triple-stamping=shaver.

Comment 5

[Brendan Eich [:brendan]]

Fixed.  Could justify this on branches at some point, but not clear it would
make GreaseMonkey's (or anyone else's) life simpler, given downrev 1.0.x clients
in the field that would need a workaround (which we have, I worked it out with
Aaron on IRC today -- don't ask!).

/be

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

The compiler complains about this code:
jsapi.c:4482: warning: control reaches end of non-void function

Can we have a return value here, please?

Comment 7

[Mike Shaver (:shaver emeritus)]

I just fixed that, sorry for missing it on review.