301363 - Auto-highlight of URLs with parentheses produces wrong link

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[jsnod]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050719 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050719 Firefox/1.0+

If you receive an email containing a URL in the body which contains parentheses,
such as http://www.discogs.com/artist/Ilya+(2) , the auto-linkifying of the URL
fails by forgetting to include the closing ')' in the link.  If you click on the
example link from within an email, it will take you to
http://www.discogs.com/artist/Ilya+(2

Another example: http://wikisource.org/wiki/Middle_East_Policy_(Chomsky)

RFC 2396 (http://www.ietf.org/rfc/rfc2396.txt) states that parentheses are valid
characters within a URL, so these should be handled correctly and linkified as
expected.

Reproducible: Always

Steps to Reproduce:
1. Send yourself an email containing the following URL:
http://www.discogs.com/artist/Ilya+(2)
2. Open the email, notice the closing ')' is not linkified
3. Click the link

Actual Results:  
Browser launches and takes you to http://www.discogs.com/artist/Ilya+(2

Expected Results:  
Browser should launch and take you to http://www.discogs.com/artist/Ilya+(2)

Comment 1

[jsnod]

Hmm.. looks like bugzilla suffers from the same bug.  :)

Comment 2

[zug_treno]

Duplicate of/related to Core bug 133016?

Comment 3

[Adam Guthrie]

*** This bug has been marked as a duplicate of 133016 ***

Comment 4

[Ben Bucksch (:BenB)]

You just gave a reason why this is WONTFIX:
> RFC 2396 (http://www.ietf.org/rfc/rfc2396.txt) sta...
> such as http://www.discogs.com/artist/Ilya+(2) , the au

How is the code supposed to know to not include the ")" in the first line, while
including it in the second line?

That's why the URLs you gave won't be fixed in bug 133016, at most URLs having
")" in the middle (not at the end).

Comment 5

[Ben Bucksch (:BenB)]

WONTIFX

Comment 6

[jsnod]

(http://www.ietf.org/rfc/rfc2396.txt)
vs.
http://www.discogs.com/artist/Ilya+(2)

Because in the first link, the opening '(' occurs before the 'http://' begins. 
That can be used as a testcase to see whether or not to linkify the closing ')'.

If it finds a closing ')' it should check if there is a matching '(' before or
after http://.  If one occurs AFTER the 'http://', the second ')' should be
linkified, if there is not, it shouldn't.

Comment 7

[Ben Bucksch (:BenB)]

> Because in the first link, the opening '(' occurs before the 'http://' begins.

That's not always the case (like here https://bugzi...). How far do we search
back? It might cross linebreaks, in which case I have no way to know. And it's
too complicated anyways, esp. for a fringe case that shouldn't exist in the
first place.