Closed
Bug 301385
Opened 19 years ago
Closed 19 years ago
static EnumHelp function is unused
Categories
(Toolkit :: Startup and Profile System, defect, P1)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: darin.moz, Assigned: benjamin)
Details
(Whiteboard: has patch with review)
Attachments
(1 file)
|
1.28 KB,
patch
|
darin.moz
:
first-review+
shaver
:
approval1.8b4+
|
Details | Diff | Splinter Review |
I noticed while reading through nsCommandLine.cpp that the static function EnumHelp is unused. It seems to me that it should be used from nsCommandLine::GetHelpText, but it is not. Instead, that function calls EnumRun. That seems pretty wrong to me.
|
Reporter | |
Comment 1•19 years ago
|
||
Yeah, this really seems to be broken. When I run "firefox -help" I see exceptions from nsBrowserContentHandler.js about not being able to open a new window.
OS: Linux → All
Hardware: PC → All
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.8b4+
|
|
Assignee | |
Comment 2•19 years ago
|
||
*blush*
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189928 -
Flags: first-review?(darin)
|
|
Reporter | |
Updated•19 years ago
|
Attachment #189928 -
Flags: first-review?(darin) → first-review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189928 -
Flags: approval1.8b4?
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Whiteboard: has patch with review
Target Milestone: --- → mozilla1.8beta4
Comment on attachment 189928 [details] [diff] [review] Use EnumHelp, rev. 1 a=shaver
Attachment #189928 -
Flags: approval1.8b4? → approval1.8b4+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk for 1.8b4
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
You need to log in
before you can comment on or make changes to this bug.
Description
•