static EnumHelp function is unused

RESOLVED FIXED in mozilla1.8beta4

Status

()

Toolkit
Startup and Profile System
P1
normal
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Darin Fisher, Assigned: Benjamin Smedberg)

Tracking

unspecified
mozilla1.8beta4
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: has patch with review)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
I noticed while reading through nsCommandLine.cpp that the static function
EnumHelp is unused.  It seems to me that it should be used from
nsCommandLine::GetHelpText, but it is not.  Instead, that function calls
EnumRun.  That seems pretty wrong to me.
(Reporter)

Comment 1

13 years ago
Yeah, this really seems to be broken.  When I run "firefox -help" I see
exceptions from nsBrowserContentHandler.js about not being able to open a new
window.
OS: Linux → All
Hardware: PC → All
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: blocking1.8b4+
(Assignee)

Comment 2

13 years ago
Created attachment 189928 [details] [diff] [review]
Use EnumHelp, rev. 1

*blush*
(Assignee)

Updated

13 years ago
Attachment #189928 - Flags: first-review?(darin)
(Reporter)

Updated

13 years ago
Attachment #189928 - Flags: first-review?(darin) → first-review+
(Assignee)

Updated

13 years ago
Attachment #189928 - Flags: approval1.8b4?
(Assignee)

Updated

13 years ago
Priority: -- → P1
Whiteboard: has patch with review
Target Milestone: --- → mozilla1.8beta4
Comment on attachment 189928 [details] [diff] [review]
Use EnumHelp, rev. 1

a=shaver
Attachment #189928 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 4

13 years ago
Fixed on trunk for 1.8b4
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
You need to log in before you can comment on or make changes to this bug.