301398 - Make XUL links accessible -- round two

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

In a number of places XUL <label>'s have onclick handlers. Luckily the onclick
for these XUL elements will also accept Enter as a click.

These interactive elements should be exposed at least as a button, and perhaps
as a link.

The XUL link accessible class that Peter Parente wrote is already smart about
how to handle an interactive label, and whether to expose it as a link or a
button. If there is an href attribute it will expose it has a link, otherwise as
a button.

Fixing this will make the download/extension/theme manager "links" be spoken as
buttons or links, as appropriate, instead of "static text" which confuses people.

Comment 1

[Aaron Leventhal]

Attachment: 1) Go from 4 kinds of links down to 2 (label class="text-link" and <link>)

Comment 2

[Aaron Leventhal]

Attachment: Also fix JS console links

Comment 3

[Aaron Leventhal]

Doron, this has some changes in richlistbox.xml.

Comment 4

[Aaron Leventhal]

Attachment: Also fix links in Help->About and Help->Report a broken website

Okay, now I think I really have all the links. A search in lxr for "#0x0000ff"
showed me more places we were styling links.

Comment 5

[Aaron Leventhal]

Please ignore the changes in preferences.xml. That's part of another bug which 
was already landed.

Comment 6

[Aaron Leventhal]

Attachment: onclick unnecessary in reporter link since we need to set the href there to make it a link

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 190320 [details] [diff] [review]
onclick unnecessary in reporter link since we need to set the href there to make it a link

r+a=me with the changes discussed (replacing the black border with
-moz-dialogText)

Comment 8

[Aaron Leventhal]

Checking in toolkit/content/xul.css;
/cvsroot/mozilla/toolkit/content/xul.css,v  <--  xul.css
new revision: 1.61; previous revision: 1.60
done
Checking in toolkit/content/widgets/richlistbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/richlistbox.xml,v  <--  richlistbox.xml
new revision: 1.10; previous revision: 1.9
done
Checking in toolkit/mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v  <--  download.xml
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/mozapps/downloads/content/downloads.css;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.css,v  <-- 
downloads.css
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.68; previous revision: 1.67
done
Checking in toolkit/mozapps/extensions/content/extensions.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xul,v  <-- 
extensions.xul
new revision: 1.35; previous revision: 1.34
done
Checking in toolkit/mozapps/extensions/content/about.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/about.xul,v  <--  about.xul
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/mozapps/update/content/updates.xml;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.xml,v  <--  updates.xml
new revision: 1.31; previous revision: 1.30
done
Checking in toolkit/themes/pinstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/formatting.css,v  <-- 
formatting.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.7; previous revision: 1.6
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.12; previous revision: 1.11
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/about.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/about.css,v  <-- 
about.css
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/qute/communicator/formatting.css;
/cvsroot/mozilla/toolkit/themes/qute/communicator/formatting.css,v  <-- 
formatting.css
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/themes/qute/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/qute/global/formatting.css,v  <--  formatting.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/themes/qute/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/downloads/downloads.css,v  <-- 
downloads.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/themes/qute/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css,v  <-- 
extensions.css
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/themes/qute/mozapps/extensions/update.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/update.css,v  <-- 
update.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/qute/mozapps/extensions/about.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/about.css,v  <--  about.css
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/formatting.css,v  <-- 
formatting.css
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.11; previous revision: 1.10
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.15; previous revision: 1.14
done
Checking in toolkit/themes/winstripe/mozapps/extensions/update.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/update.css,v  <-- 
update.css
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/mozapps/extensions/about.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/about.css,v  <-- 
about.css
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/themes/winstripe/mozapps/update/update.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/update.css,v  <-- 
update.css
new revision: 1.7; previous revision: 1.6
done
Checking in toolkit/components/console/content/consoleBindings.xml;
/cvsroot/mozilla/toolkit/components/console/content/consoleBindings.xml,v  <-- 
consoleBindings.xml
new revision: 1.8; previous revision: 1.7
done
Checking in extensions/reporter/resources/content/reporter/reportWizard.xul;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.xul,v
 <--  reportWizard.xul
new revision: 1.10; previous revision: 1.9
done
Checking in extensions/reporter/resources/skin/classic/reporter/reportWizard.css;
/cvsroot/mozilla/extensions/reporter/resources/skin/classic/reporter/reportWizard.css,v
 <--  reportWizard.css
new revision: 1.4; previous revision: 1.3
done

Comment 9

[Aaron Leventhal]

Reopening for changes to mozilla/accessible to recognize <link> as used in
update wizard.

Comment 10

[Aaron Leventhal]

Attachment: Recognize <link> as a xul link

Comment 11

[parente]

Comment on attachment 190441 [details] [diff] [review]
Recognize <link> as a xul link

nit: "is" missing from comment line in nsXULTextAccessible.cpp (problem from my
original patch)

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 190441 [details] [diff] [review]
Recognize <link> as a xul link

sr=bzbarsky with that comment fixed.

Comment 13

[Aaron Leventhal]

Checking in src/xul/nsXULTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULTextAccessible.cpp,v  <-- 
nsXULTextAccessible.cpp
new revision: 1.17; previous revision: 1.16
done
Checking in src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <-- 
nsAccessibilityAtomList.h
new revision: 1.29; previous revision: 1.28
done