HideWindowChrome sets fullscreen mode in GTK2 nsWindow

RESOLVED FIXED

Status

()

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is pretty bogus. If you want to use HideWindowChrome (via hidechrome="true"
in the XUL <window>) then we try to make the window fullscreen instead of hiding
the chrome.

The solution is really simple: have nsWindow::HideWindowChrome just hide the
chrome, and override MakeFullScreen to do the fullscreen thing.
Created attachment 189860 [details] [diff] [review]
fix

Obvious patch. I've ensured that MakeWindowFullScreen does exactly the same
things that it used to do. Only users of HideWindowChrome outside of
MakeWindowFullScreen will be affected.
Attachment #189860 - Flags: superreview?(blizzard)
Attachment #189860 - Flags: review?(blizzard)
Attachment #189860 - Flags: superreview?(blizzard)
Attachment #189860 - Flags: superreview+
Attachment #189860 - Flags: review?(blizzard)
Attachment #189860 - Flags: review+
Comment on attachment 189860 [details] [diff] [review]
fix

widget bug that makes the XUL hidechrome="true" not work on GTK2. Low risk.
Attachment #189860 - Flags: approval1.8b4?
Comment on attachment 189860 [details] [diff] [review]
fix

a=shaver
Attachment #189860 - Flags: approval1.8b4? → approval1.8b4+
checked in
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.