301402 - HideWindowChrome sets fullscreen mode in GTK2 nsWindow

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is pretty bogus. If you want to use HideWindowChrome (via hidechrome="true"
in the XUL <window>) then we try to make the window fullscreen instead of hiding
the chrome.

The solution is really simple: have nsWindow::HideWindowChrome just hide the
chrome, and override MakeFullScreen to do the fullscreen thing.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Obvious patch. I've ensured that MakeWindowFullScreen does exactly the same
things that it used to do. Only users of HideWindowChrome outside of
MakeWindowFullScreen will be affected.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 189860 [details] [diff] [review]
fix

widget bug that makes the XUL hidechrome="true" not work on GTK2. Low risk.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 189860 [details] [diff] [review]
fix

a=shaver

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in