301420 - Behaviour of preferences toolbar "roll-up" not compliant with Aqua GUI

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[Tom Boyce]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

When "rolling-up" the preferences toolbar using the pill shaped button in
DeerPark Alpha 2 the window does not behave correctly. Proper bahvior would
shrink the height of the window to compensate for the lack of toolbar (see
safari) in DeerPark Alpha 2 the window height remains the same as before
"rolling-up" the toolbar.

Reproducible: Always

Steps to Reproduce:
1.Open preferences
2.Use pill shaped button rollup toolbar
3.Observe window height

Actual Results:  
The window height remains the same as before "rolling-up" the toolbar.

Expected Results:  
The window height should change to reflect the height of the toolbar.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Note: this doesn't improve our behavior in the general case (that's, a browser
window) where our current behavior might be even useful... :-/

Comment 2

[jhp (no longer active)]

I just tested this patch, and I see how it works for the Preferences window. 
But why doesn't it work for the main browser window?  I have noticed, though,
that this patch makes the browser window grow horizontally if you repeatedly
press the toolbar button.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 189881 [details] [diff] [review]
patch

Oh really, going to check that...

Comment 4

[Markus Amalthea Magnuson]

Closing since this isn't valid anymore, due to the removal of the pill button in bug 573412.