301432 - Gmail link clicks not recognized during compose.

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P2)

Description

[Chris Wells]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050719 Camino/0.9a2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050719 Camino/0.9a2

When composing a new message in Gmail's standard interface, after adding any
text to the "To:" form field none of the links anywhere else on the page
register clicks.  The Send / Save Draft / Cancel form elements do still work.

I have been able to reproduce this bug with 0.9a2 and the latest nightly (7/19)
both with my original profile settings (~/Library/Application Support/Camino)
and with a completely fresh profile.  The problem does not occur in "Basic HTML"
Mode.

Reproducible: Always

Steps to Reproduce:
1. Login to Gmail
2. Make sure you are in "standard" (not Basic HTML) mode.
3. Click "Compose Mail" in the upper left-hand corner.
4. Add any text to the "To:" form field.

Actual Results:  
No link clicks anywhere on the Gmail page register.

Expected Results:  
Clicking on a link should lead you to a different page.

OS X version: 10.3.9

uname -a
Darwin converge.local 7.9.0 Darwin Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST
2005; root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC  Power Macintosh powerpc

Comment 1

[Samuel Sidler (old account; do not CC)]

Weird. Does this work in a Deer Park nightly?

Confirming...

Comment 2

[Samuel Sidler (old account; do not CC)]

Oh, forgot to say. I'm using 2005071708. Also, the "Sign out" link works fine.

Comment 3

[Samuel Sidler (old account; do not CC)]

When you say this works in Firefox, is it v1.x.x? Or are you using a nightly? If
you aren't using an nightly, can you please try this in a Firefox nightly?

Comment 4

[Chris Wells]

I hadn't tested with Firefox before reporting the bug.  I just downloaded the
latest nightly and it appears to work as expected.  While composing a message,
if I click a link I get an alert box confirming that I want to discard the
message, and am redirected to the proper page.

UA: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4)
Gecko/20050719 Firefox/1.0+

Back in Camino, the "Sign Out" and "Help" links also work for me.  I think those
are the only two links that do not trigger the alert box confirming that the
message will be discarded.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> Back in Camino, the "Sign Out" and "Help" links also work for me.  I think those
> are the only two links that do not trigger the alert box confirming that the
> message will be discarded.

Did this break about the 28th/29th?  That's when bug 298320 landed, which is the
Camino-specific latest checkin to have something to do with JS/prompts....

Comment 6

[Chris Wells]

(In reply to comment #5)
> 
> Did this break about the 28th/29th?  That's when bug 298320 landed, which is the
> Camino-specific latest checkin to have something to do with JS/prompts....

I can't say for sure.  I ran a couple of different nightlies between 0.9a1 and
0.9a2 but wasn't very consistent.

I just confirmed on my roommate's computer that 0.9a1 (20050620) does not have
this problem; clicking a link while composing a message brings up the javascript
prompt as expected.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I can't grab the 29th's build right now to verify for sure, but cc'ing Simon on
the hunch that it was bug 298320 that regressed this....

Comment 8

[Simon Fraser [no longer active]]

Yeah, the nsIDOMWindow that we get in Confirm() is that for a subframe, so
[CHBrowserView browserViewFromDOMWindow:parent] is returning nil and we bail.

Comment 9

[Simon Fraser [no longer active]]

Attachment: Patch

Patch uses nsIDOMWindow::GetTop() to get the top window in the frameset when
looking for the corresponding CHBrowserView.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 301497 has been marked as a duplicate of this bug. ***

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 189942 [details] [diff] [review]
Patch

I'm gonna check this in.

Comment 12

[Simon Fraser [no longer active]]

Fixed.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 304742 has been marked as a duplicate of this bug. ***