301438 - While page is loading, scrolling to page id/named anchor not working when opened link inside document

Status: REOPENED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

To reproduce, you probably need a not too fast internet connection.

- Open url
- While page is loading, click on the "9.3 Positioning schemes" link, for
instance. That page id/named anchor should not be available, yet.

When the page is done loading, the browser still doesn't scroll to the named
anchor. 
I would expect that to happen as soon as the page id/named anchor became available.

IE6 is doing this correct.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So... this is an interesting question.  If I click on an anchor and then a named anchor with that name is placed in the DOM via DOM methods, should we scroll to it?  Why is that case different from the parsing case, in general?

I can probably hack things so that if the document has a content sink we set the ref on the content sink, but is that really what we want?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

IMHO we want to do this. The reason this is different during parsing is that it's just less surpricing for the page to scroll during loading when so many other things are still going on anyway.

But once the page is loaded and the user starts using it I think it would be very unexpected if we 'suddenly' scrolled to some new place. See also bug 301438.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK.  So what do you think of my proposal?  The current control flow on a link click right now is that docshell explicitly scrolls presshell to anchor.  We'd have to get the document involved somehow so that it can pass the info on to the sink...

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sounds like an excellent solution. Once bug 103279 (which is the bug i ment to refer to above) is fixed it should integrate with that.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK.  So I guess we need:

1)  A method on nsIDocument to set stuff on the sink
2)  A method on nsIContentSink
3)  Docshell code to let the document know

The docshell should probably still scroll the presshell...

Seems messy to me (in terms of docshell depending on various guts), but I don't really see a better solution.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If you're changing anchor scrolling, consider fixing (parts of) bug 103279 while you're there (see esp. bug 103279 comment 9 and bug 103279 comment 16).

Comment 7

[arpit]

Check the version of browser