Move CheckEmailSyntax out of CGI.pl

RESOLVED FIXED in Bugzilla 2.22

Status

()

--
enhancement
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

2.21
Bugzilla 2.22
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
this routine is used by many different files... should go into Util.pm.

Updated

13 years ago
Target Milestone: --- → Bugzilla 2.22
(Assignee)

Comment 1

13 years ago
Created attachment 189905 [details] [diff] [review]
patch, v1
Assignee: general → LpSolit
Status: NEW → ASSIGNED
Attachment #189905 - Flags: review?(mkanat)

Comment 2

13 years ago
Comment on attachment 189905 [details] [diff] [review]
patch, v1

Looks good, works in a basic test, passes runtests.

I think we should have check_email_syntax return a trick_tainted $addr if the
email is valid, but that's probably another bug.
Attachment #189905 - Flags: review?(mkanat) → review+

Updated

13 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 3

13 years ago
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.248; previous revision: 1.247
done
Checking in createaccount.cgi;
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v  <--  createaccount.cgi
new revision: 1.41; previous revision: 1.40
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.20; previous revision: 1.19
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.92; previous revision: 1.91
done
Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.33; previous revision: 1.32
done
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.78; previous revision: 1.77
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.65; previous revision: 1.64
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.31; previous revision: 1.30
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.