301458 - Move url_decode out of CGI.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

should go into Util.pm

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I forgot the POD docs in bug 301453 for check_email_syntax. Adding them here
together with url_decode.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 189910 [details] [diff] [review]
patch, v1

  OK on inspection, but certain parts of the POD docs need to be fixed:

>@@ -408,6 +426,9 @@
>   # Cryptographic Functions
>   $crypted_password = bz_crypt($password);
> 
>+  # Functions for email syntax validation

  Just "validation functions" in general.

>@@ -630,3 +655,13 @@
> =end undocumented
> 
> =back
>+
>+=head2 Email syntax validation

  Same note here.

>+=item C<check_email_syntax($email)>
>+
>+Do a syntax checking for a legal email address.

  Note that the function actually throws a user error if the email syntax is
invalid.


  Also, the "url_decode" POD docs probably want to be more specific than "get
rid of," since that sounds like we just delete them.

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

If you have a better explanation for url_decode, please write it here and I
will do a copy and paste. ;)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 189915 [details] [diff] [review]
patch, v2

OK, except "an error is thrown" instead of "an error is returned."

I think that can be fixed on checkin, though. :-)

Comment 5

[Frédéric Buclin]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.249; previous revision: 1.248
done
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.147; previous revision: 1.146
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.32; previous revision: 1.31
done