301476 - Should XPC_NW_CheckAccess always call the checkAccess hook on the wrapped native?

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I don't see why XPCWrappedNative should only call the checkAccess hook on the
underlying native wrapper in the bypass case.  It seems to me that we'd
basically want to do this any time... but maybe I'm missing something?

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think we need to at least think about this for 1.8b4

Comment 2

[Boris Zbarsky [:bzbarsky]]

I meant XPCNativeWrapper in comment 0, of course....

Comment 3

[Corinne Bordelon]

jst -> dveditz supposes that this is related to split windows. Would you mind
taking a look to see if it should block the beta?

Comment 4

[Johnny Stenback (:jst)]

Attachment: Unconditionally forward checkAccess() calls to the wrapped native's JSObject.

Better safe than sorry, and I can't think of a case where we *don't* want this.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 192144 [details] [diff] [review]
Unconditionally forward checkAccess() calls to the wrapped native's JSObject.

The canonical name for clazz is clasp, of course ;-).  sr=me in any case.

/be

Comment 6

[Johnny Stenback (:jst)]

The jband-canonical name for clasp is clazz :)

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 192144 [details] [diff] [review]
Unconditionally forward checkAccess() calls to the wrapped native's JSObject.

r=shaver

Comment 8

[Johnny Stenback (:jst)]

Fixed on trunk.

Comment 9

[Johnny Stenback (:jst)]

Fixed on the 1.8 branch too.