Palm sync does not build with latest platform SDK

RESOLVED FIXED in mozilla1.8beta4

Status

MailNews Core Graveyard
Palm Sync
P1
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8beta4
x86
Windows XP

Details

(URL)

Attachments

(1 attachment)

Palm sync does not build with the latest platform SDK
it hits this #error in a midl-generated proxy file:
#if !(TARGET_IS_NT40_OR_LATER)
#error You need a Windows NT 4.0 or later to run this stub because it uses these
features:
#error   -Oif or -Oicf.
#error However, your C/C++ compilation flags indicate you intend to run this app
on earlier systems.
#error This app will die there with the RPC_X_WRONG_STUB_VERSION error.
#endif
Created attachment 189952 [details] [diff] [review]
patch

I'm using -Oic because
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/midl/midl/_target.asp
sounds to me like the other options require an NT-based windows, and I'm not
sure palmsync should be limited to that.
Attachment #189952 - Flags: review?(benjamin)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta4

Comment 3

13 years ago
Comment on attachment 189952 [details] [diff] [review]
patch

I would like this to get review by somebody who knows palmsync as well, but it
looks fine to me and does not look as if it will affect the actual interface
layout at all, only the stubbing.
Attachment #189952 - Flags: review?(benjamin) → review+
Comment on attachment 189952 [details] [diff] [review]
patch

ok... I don't know who knows palmsync these days, trying bienvenu :)
Attachment #189952 - Flags: superreview?(bienvenu)

Comment 5

13 years ago
Comment on attachment 189952 [details] [diff] [review]
patch

yep, palmsync is me.
Attachment #189952 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 189952 [details] [diff] [review]
patch

fixes palmsync compilation with the latest sdk; should be low risk (just a
command-line argument change for midl)

requirement for turning on svg for seamonkey
Attachment #189952 - Flags: approval1.8b4?

Updated

13 years ago
Attachment #189952 - Flags: approval1.8b4? → approval1.8b4+
Checking in build/Makefile.in;
/cvsroot/mozilla/mailnews/extensions/palmsync/build/Makefile.in,v  <--  Makefile.in
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core

Updated

9 years ago
Component: Palm Sync → Palm Sync
Product: MailNews Core → MailNews Core Graveyard
You need to log in before you can comment on or make changes to this bug.