Closed Bug 301507 Opened 20 years ago Closed 20 years ago

Move PutHeader and PutFooter into Template.pm

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.21
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.22

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file, 1 obsolete file)

Till all .cgi files get templatized, we still need these two routines. They should go into Template.pm.
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.22
Attached patch patch, v1 (obsolete) — Splinter Review
PutHeader and PutFooter are now methods of Bugzilla->template and have been renamed put_header and put_footer respectively. Tested; it works fine.
Attachment #190074 - Flags: review?(justdave)
Attached patch patch, v2Splinter Review
There is a missing 'use Bugzilla::Error' in Template.pm.
Attachment #190074 - Attachment is obsolete: true
Attachment #190093 - Flags: review?(justdave)
Attachment #190074 - Flags: review?(justdave)
Attachment #190093 - Flags: review?(justdave) → review+
Flags: approval+
Checking in CGI.pl; /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.251; previous revision: 1.250 done Checking in doeditparams.cgi; /cvsroot/mozilla/webtools/bugzilla/doeditparams.cgi,v <-- doeditparams.cgi new revision: 1.34; previous revision: 1.33 done Checking in editparams.cgi; /cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v <-- editparams.cgi new revision: 1.25; previous revision: 1.24 done Checking in editproducts.cgi; /cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi new revision: 1.88; previous revision: 1.87 done Checking in move.pl; /cvsroot/mozilla/webtools/bugzilla/move.pl,v <-- move.pl new revision: 1.32; previous revision: 1.31 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.267; previous revision: 1.266 done Checking in reports.cgi; /cvsroot/mozilla/webtools/bugzilla/reports.cgi,v <-- reports.cgi new revision: 1.75; previous revision: 1.74 done Checking in sanitycheck.cgi; /cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v <-- sanitycheck.cgi new revision: 1.98; previous revision: 1.97 done Checking in Bugzilla/Template.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v <-- Template.pm new revision: 1.27; previous revision: 1.26 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: