301519 - Personal Bookmarks disappear from Bookmarks Toolbar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Pardal Freudenthal (:ShareBird)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050720 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050720 Firefox/1.0+

If you customize your toolbar to have the url bar beside your personal bookmarks
(very common for people who has migrated from IE) and minimize the window to the
taskbar on Windows, every time a live bookmarks refresh occurs, the personal
bookmarks will disappear and you will have only the url bar and the chevron on
your Bookmarks Toolbar.



Reproducible: Always

Steps to Reproduce:
1.Create a new profile.
2.Customize your toolbar putting the urlbar and the go button on the left side
of your personal bookmarks on Bookmarks Toolbar. Please see the attached image
that describes the toolbar appearance.
3.Open a new window (Ctrl+N can do the job).
4.Go to the first window you've opened and minimize it to your taskbar.
5.On the second window, right click the "Latest Headlines" folder and choose
"Reload Live Bookmark".
6.Maximize the first window.
5.Go to the second window

Actual Results:  
The urlbar is expanded and the personal bookmarks "Getting Started" and "Latest
Headlines" disappear into the chevron. Please see attached image.

Expected Results:  
The toolbar shouldn't change its appearance.

Comment 1

[Pardal Freudenthal (:ShareBird)]

Attachment: Customized toolbar

Shows the customized toolbar with urlbar on Bookmarks Toolbar

Comment 2

[Pardal Freudenthal (:ShareBird)]

Attachment: The bug

Shows how the toolbar appears after maximizing the window.

Comment 3

[Pardal Freudenthal (:ShareBird)]

Sorry for the 5. step at the end of descriptions to reproduce it. Was not intended.

Two other informations:

If you just choose to customize the toolbar and click on "Done" the toolbar will
come back to the intended appearance.
It seems to be a regression, since for a few weeks I was not able to notice this
issue. Unfortunately I can't precise when this started to happen.

Comment 4

[Pardal Freudenthal (:ShareBird)]

I was able to determine a regression point.

It happens on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3)
Gecko/20050714 Firefox/1.0+ ID:2005071406

It doesn't happen on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3)
Gecko/20050713 Firefox/1.0+ ID:2005071306

Comment 5

[Pardal Freudenthal (:ShareBird)]

The regression was caused by the fix on Bug
https://bugzilla.mozilla.org/show_bug.cgi?id=178120.
Reverting the patch for it solves this problem.

Comment 6

[Martijn Wargers (dead)]

Well, the patch from bug 178120 seems good to me.
But it seems to have caused this bug. Probably the BookmarksToolbar.resizeFunc
isn't doing the job well in this circumstance.
It's a bit strange, though, that onChange seems to be getting called when
following the steps in this bug? (from :
https://bugzilla.mozilla.org/attachment.cgi?id=188840 )

Comment 7

[Martijn Wargers (dead)]

Attachment: patch

I should have done this in bug 266737, it makes perfect sense: don't continue
with the resizeFunc when window.innerWidth = 0. 
I've tested it and I think it fixes the bug.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

+    if (width == 0) {  // hack for bug 266737
+      window.addEventListener('focus', BookmarksToolbar.resizeFunc, false); 
+      return;
+    };
      ^

Martijn, please remove the trailing semicolon.

Comment 9

[Martijn Wargers (dead)]

Attachment: patch2

Ok, done

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 190115 [details] [diff] [review]
patch2

r=vladimir

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.48; previous revision: 1.47
done