30156 - Delete Profile dialog should match N4.7's

Status: VERIFIED DUPLICATE of bug 37387

(SeaMonkey :: Startup & Profiles, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

In the aftermath of 30119 it seems that we need to put up a dialog at the lowest 
level before deleting a profile to show what folder is about to be deleted to 
allow the user to abort the procedure, to prevent against foo caused by future 
updates to the profile manager. 

e.g. "you are about to delete all files and folders in the folder c:\foo, they 
will be unrecoverable. click cancel to abort this operation" or similar. 

(requested by jar)

Comment 1

[selmer (gone)]

beta1?

Comment 2

[Phil Peterson]

[PDT+] w/b minus on 3/7

Comment 3

[selmer (gone)]

Bhuvan, any update?

Comment 4

[racham]

Working on this. Will have an update by tomorrow evening.

Comment 5

[racham]

On backend, we are initialized before the hidden window activities are done. 
Common diaog services are based on having hidden window initialization. 
 
So, currently looking at the other alternative of passing the directory name to 
frontend for the confirmation....

Comment 6

[racham]

I spoke to davidm regarding the chnages I can do in the backend using nsIPrompt. 
It is too destabilizing for beta for that changes. We can work this out via 
front end once we start using nsIRegistry and have GetProfileDir scriptable. 

Comment 7

[racham]

Once gayatri lands i18n changes, we should do this from the frontend as 
nsIRegistry can be used to query for directory name. Then a javascript confirm 
dialog can be put up. Will talk to ben regarding this one.

Comment 8

[racham]

With gayatri's changes in, now nsIRegistry can be used to query the registry for 
profile directory name. A confirm dialog can be thrown with the obtained 
directory name. Displaying confirm dialog is much easier and convenient to 
achieve i18n compatability and to alter messgae as required. As per the 
directory name, we are getting it from the registry and it is accurate.

Posting the patch (next update). Reassigning to ben.

Comment 9

[racham]

Attachment: patch to throw delete directory confirm dialog

Comment 10

[don]

Move to M16 for now ...

Comment 11

[racham]

changing the component to front-end.

Comment 12

[leger]

Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

some slight modification of delete profile dialog required + bhuvan's patch. 
Time to complete: 2 hours. 

Comment 14

[leger]

Changing from [6/01] to [6/15]

Comment 15

[don]

Move to M19.

Comment 16

[Jim Roskind]

Cleaning up status whiteboard by marking beta2 minus (6/15 has passed)

Folks are too doomed to handle this for beta2

Comment 17

[verah (gone)]

Per nav triage team: We have a dialog now. It's imperfect, but its good enough.

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Starting in N4.7, the Delete profile dialog displayed the path of the profile 
about to be deleted. Adding 4xp keyword, nominating for nsbeta3. 

Comment 19

[Paul Chen]

nav triage team:
taking this one for the gipper

Comment 20

[Michael La Guardia]

replacing nsbeta2-

Comment 21

[Michael La Guardia]

make that n*s*beta2-

Comment 22

[Phil Peterson]

PDT marking this bug a dup. Delete profile prompt is fine for Semaonkey RTM.

*** This bug has been marked as a duplicate of 37387 ***

Comment 23

[Grace Bush]

verify 

Comment 24

[Paul Chen]

*** Bug 32810 has been marked as a duplicate of this bug. ***

Comment 25

[Paul Chen]

*** Bug 32810 has been marked as a duplicate of this bug. ***