301638 - Removing src attribute of an <img> should hide the image

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

See the attached testcase. Removing the src attribute seems to have no effect,
not even if the image is removed from & reinserted into the document.

win2k, 1.7.8
winxp, seamonkey nightly 2005070205

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

See
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLImageElement.cpp#141
-- changing that should probably be enough...

Also see
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLInputElement.cpp#451
 for the equivalent <input type="image"> thing.

Comment 3

[Boris Zbarsky [:bzbarsky]]

And the problem, of course, is that we can't just call ImageURIChanged there
since we're not looking at a null URI.  We probably want to call
CancelImageRequests and then trigger a reframe or something...

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

triggering the reframe should now be done automatically, via the state change
notifications.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Right.  So just CancelImageRequests might work.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ian, does HTML5 define this?

Comment 7

[Simon Pieters [:zcorpan]]

"A user agent that obtains images immediately must also synchronously update the image data of an img element whenever that element ... has its src, ... attribute set, changed, or removed,"

http://www.whatwg.org/specs/web-apps/current-work/multipage/edits.html#the-img-element

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.