301647 - [Mac] remove support of retrieving the 'system' download folder from nsDirectoryService::GetFile

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P3)

Description

[Asaf Romano (gone)]

Starting from OS X 10.3, the InternetConfig download-folder pref is a Safari
oriented preference. As nsDirectoryService::GetFile is expected to return only
system files/folders locations, we should remove its support of retrieving the
InternetConfig download folder pref.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[jhp (no longer active)]

So, you mean that in 10.2, there used to be a preference in System Preferences
to set the system's download folder.  But in 10.3+, that moved into Safari?

Comment 3

[Asaf Romano (gone)]

Yes, together with the whole (old) Internet preferences pane.

Comment 4

[jhp (no longer active)]

There are several |NS_GetSpecialDirectory(NS_MAC_DEFAULT_DOWNLOAD_DIR,
getter_AddRefs(downloadsDir))| calls throughout the code.  What happens to those
with this patch?

Comment 5

[Asaf Romano (gone)]

Comment on attachment 190108 [details] [diff] [review]
patch

I didn't realiz we have both NS_OSX_DEFAULT_DOWNLOAD_DIR and
NS_MAC_DEFAULT_DOWNLOAD_DIR

Comment 6

[Doug Turner (:dougt)]

josh or simon can review this or any mac specific patch.

Comment 7

[Till Korten]

Another reason to resolve this bug together with bug 473763 and part of bug 311292 is that since Safari 3 the possibility to change the system download folder is gone altogether. Additionally, the default being the Desktop is _very_ annoying, since it causes firefox to clutter the desktop. Bug 473763 proposes a patch (attachment 356833 [details] [diff] [review]) that I (admittedly being the reporter of this bug) think would solve the situation elegantly.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Shawn, now that bug 454242 is fixed what has to be done to fix this bug?

Comment 9

[Shawn Wilsher :sdwilsh]

(In reply to comment #8)
> Shawn, now that bug 454242 is fixed what has to be done to fix this bug?
I don't know mac APIs - better off asking someone like josh probably.

Comment 10

[Shawn Wilsher :sdwilsh]

I'm fixing this over in bug 476174.

Comment 11

[Shawn Wilsher :sdwilsh]

Fixed by http://hg.mozilla.org/mozilla-central/rev/4d7f404d3aa3

Comment 12

[Shawn Wilsher :sdwilsh]

Also fixed by http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9a5927efbd10 on 1.9.1