Closed Bug 301647 Opened 16 years ago Closed 12 years ago
[Mac] remove support of retrieving the 'system' download folder from ns
Directory Service::Get File
Starting from OS X 10.3, the InternetConfig download-folder pref is a Safari oriented preference. As nsDirectoryService::GetFile is expected to return only system files/folders locations, we should remove its support of retrieving the InternetConfig download folder pref.
16 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.8beta4
16 years ago
So, you mean that in 10.2, there used to be a preference in System Preferences to set the system's download folder. But in 10.3+, that moved into Safari?
Yes, together with the whole (old) Internet preferences pane.
There are several |NS_GetSpecialDirectory(NS_MAC_DEFAULT_DOWNLOAD_DIR, getter_AddRefs(downloadsDir))| calls throughout the code. What happens to those with this patch?
Comment on attachment 190108 [details] [diff] [review] patch I didn't realiz we have both NS_OSX_DEFAULT_DOWNLOAD_DIR and NS_MAC_DEFAULT_DOWNLOAD_DIR
josh or simon can review this or any mac specific patch.
16 years ago
15 years ago
Target Milestone: mozilla1.8beta4 → mozilla1.9beta
14 years ago
Assignee: bugs.mano → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.9beta → ---
Another reason to resolve this bug together with bug 473763 and part of bug 311292 is that since Safari 3 the possibility to change the system download folder is gone altogether. Additionally, the default being the Desktop is _very_ annoying, since it causes firefox to clutter the desktop. Bug 473763 proposes a patch (attachment 356833 [details] [diff] [review]) that I (admittedly being the reporter of this bug) think would solve the situation elegantly.
Shawn, now that bug 454242 is fixed what has to be done to fix this bug?
Component: XPCOM → File Handling
QA Contact: xpcom → file-handling
Hardware: PowerPC → All
(In reply to comment #8) > Shawn, now that bug 454242 is fixed what has to be done to fix this bug? I don't know mac APIs - better off asking someone like josh probably.
I'm fixing this over in bug 476174.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
No longer depends on: 311292
Whiteboard: [to be fixed by bug 476174] → [fixed by bug 476174]
Target Milestone: --- → mozilla1.9.2a1
Also fixed by http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9a5927efbd10 on 1.9.1
You need to log in before you can comment on or make changes to this bug.