Closed Bug 301647 Opened 16 years ago Closed 12 years ago

[Mac] remove support of retrieving the 'system' download folder from nsDirectoryService::GetFile

Categories

(Core Graveyard :: File Handling, defect, P3)

All
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mano, Assigned: sdwilsh)

References

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed by bug 476174])

Attachments

(1 obsolete file)

Starting from OS X 10.3, the InternetConfig download-folder pref is a Safari
oriented preference. As nsDirectoryService::GetFile is expected to return only
system files/folders locations, we should remove its support of retrieving the
InternetConfig download folder pref.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.8beta4
Attached patch patch (obsolete) — Splinter Review
Attachment #190108 - Flags: superreview?(sfraser_bugs)
Attachment #190108 - Flags: review?(jhpedemonte)
So, you mean that in 10.2, there used to be a preference in System Preferences
to set the system's download folder.  But in 10.3+, that moved into Safari?
Yes, together with the whole (old) Internet preferences pane.
There are several |NS_GetSpecialDirectory(NS_MAC_DEFAULT_DOWNLOAD_DIR,
getter_AddRefs(downloadsDir))| calls throughout the code.  What happens to those
with this patch?
Comment on attachment 190108 [details] [diff] [review]
patch

I didn't realiz we have both NS_OSX_DEFAULT_DOWNLOAD_DIR and
NS_MAC_DEFAULT_DOWNLOAD_DIR
Attachment #190108 - Flags: superreview?(sfraser_bugs)
Attachment #190108 - Flags: review?(jhpedemonte)
Attachment #190108 - Flags: review?(dougt)
josh or simon can review this or any mac specific patch.
Attachment #190108 - Attachment is obsolete: true
Attachment #190108 - Flags: review-
Target Milestone: mozilla1.8beta4 → mozilla1.9beta
Depends on: 311292
Assignee: bugs.mano → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.9beta → ---
Another reason to resolve this bug together with bug 473763 and part of bug 311292 is that since Safari 3 the possibility to change the system download folder is gone altogether. Additionally, the default being the Desktop is _very_ annoying, since it causes firefox to clutter the desktop. Bug 473763 proposes a patch (attachment 356833 [details] [diff] [review]) that I (admittedly being the reporter of this bug) think would solve the situation elegantly.
Shawn, now that bug 454242 is fixed what has to be done to fix this bug?
Component: XPCOM → File Handling
QA Contact: xpcom → file-handling
Hardware: PowerPC → All
(In reply to comment #8)
> Shawn, now that bug 454242 is fixed what has to be done to fix this bug?
I don't know mac APIs - better off asking someone like josh probably.
I'm fixing this over in bug 476174.
Assignee: nobody → sdwilsh
Blocks: 468509
Status: NEW → ASSIGNED
Depends on: 476174
Whiteboard: [to be fixed by bug 476174]
Fixed by http://hg.mozilla.org/mozilla-central/rev/4d7f404d3aa3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
No longer depends on: 311292
Whiteboard: [to be fixed by bug 476174] → [fixed by bug 476174]
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.