301664 - Hook for field-descs.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Max Kanat-Alexander]

For people customizing their Bugzilla and adding new fields, a hook in
field-descs.html.tmpl would be really helpful.

Comment 1

[Max Kanat-Alexander]

Attachment: "end" hook for field-descs

Add it to the end, so that we can modify the vars that come before.

Comment 2

[Max Kanat-Alexander]

I'm not sure what our policy is on adding hooks to branches -- does this go as
far back as 2.18, or only to 2.22?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

>I'm not sure what our policy is on adding hooks to branches -- does this go as
>far back as 2.18, or only to 2.22?

This should go into 2.20 as well as the branch.

Comment 4

[Max Kanat-Alexander]

Unfortunately, I've discovered, because of the blocker, this hook isn't very useful.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 190099 [details] [diff] [review]
"end" hook for field-descs

After applying this patch, I created
template/en/extension/hook/global/field-descs.none.tmpl/end/foo.html.tmpl with
the following text:

[% status_descs.UNCONFIRMED = "argh" %]

Upon reloading query.cgi, the first value in the Status multiple-select menu
was "argh" rather than "UNCONFIRMED", so this patch actually works as intended
as far as I can tell.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Provided Max confirms that I'm right about the patch working as intended, this
should go into 2.20.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 190099 [details] [diff] [review]
"end" hook for field-descs

Max, can you try this patch again and see if it works for you?

Comment 8

[Max Kanat-Alexander]

Comment on attachment 190099 [details] [diff] [review]
"end" hook for field-descs

Yeah, you're right. It seems to work fine on my tip installation on landfill.
I'm not sure why it didn't work on my other 2.20. Ah well.

Comment 9

[Max Kanat-Alexander]

I hate to be pedantic, but I don't think I would have *blocked* the release on
this, so I don't think we should set blocking2.20+. Having the Target Milestone
at 2.20 is OK, I think.

Tip:

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.12; previous revision: 1.11
done

2.20:
Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.10.2.2; previous revision: 1.10.2.1
done