301668 - Changing Cache Folder applies immediately, not after clicking OK

Status: NEW

(SeaMonkey :: Preferences, defect)

Description

[Frank Wein [:mcsmurf]]

When you change the Cache Folder pref under Advanced->Cache, you'll notice that
the pref for this will be changed immediately, you can check this by looking at
the pref browser.cache.disk.parent_directory under about:config. The changed
setting should only apply as soon as you click OK.

Comment 1

[OstGote!]

Same for Mozilla 1.7.10. Even if you cancel the dialog the pref stays changed!

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190252 [details] [diff] [review]
Patch

r-, see irc comments

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190260 [details] [diff] [review]
Patch 2

+  if (!getCachedFolder())

make that: if (!gCacheParentDirectory)

+  var cacheParentDir;

where does this get a value?

Comment 7

[Frank Wein [:mcsmurf]]

Attachment: Patch 3

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190294 [details] [diff] [review]
Patch 3

+  gCacheParentDirectory = getCachedFolder();

I'd have put it immediately before the if...

+  if (folderObject instanceof Components.interfaces.nsILocalFile)

oh... on irc, I wasn't aware that this file did define a constant nsILocalFile.
so, please remove the |Components.interfaces.| part

Thank you for doingh this work! And thank you for putting up with my often
confusing comments :-)

r=biesi

Comment 9

[[e-mail]]

Comment on attachment 190294 [details] [diff] [review]
Patch 3

Sorry, that's not how you're supposed to use item data. You're supposed to
store data as properties on the object, rather than replacing the object.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190294 [details] [diff] [review]
Patch 3

OK, I want to retract my review. I've known all the time that I was the wrong
person to put a r= stamp on something involving WSM.

Comment 11

[Serge Gautherie (:sgautherie)]

Can you reproduce with SeaMonkey v1.1.9 ?
Can you reproduce with SeaMonkey v2.0a1pre ?

Frank,
Are you still working on this ?