301672 - Breadcrumbs extension needs to use '.' in addition to ':' to seperate pages

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect, P1)

Description

[Justin Wood (:Callek)]

The breadcrumbs extension needs to also use '.' to seperate pages to facilitate
window.open type page-names.  This should not assume anything about "what comes
later" to allow uses like:

Gecko_DOM_Reference:window.open:page1

to link like

Gecko_DOM_Reference > window > open > page1

patch forthcoming

Comment 1

[Justin Wood (:Callek)]

Attachment: Allow '.'

This should do it;

See (temporarily hosted) http://drapostles.hypermart.net/test.php for a running
copy of the biggest change here.
and http://drapostles.hypermart.net/test.php.txt for source of the test file.

Comment 2

[Justin Wood (:Callek)]

See Bug 301677 for what I envision we can do once this is applied.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 190103 [details] [diff] [review]
Allow '.'

>+//Note this extension only works, as written for PHP version 4.0.5 and up
> $wgExtensionFunctions[] = "mzBreadcrumbs";

Remove bogus comma, and explain what the specific dependency is that requires
4.0.5+. 

>+    //two array shifts here will grab the ":" and fixup $parts at the same time.

Can you elaborate on "fixup" (and spell it as "fix up"), please?

>+  for ($i =0; $i < count($parts ); $i+=2 ) {
>+    if ( $i > 1 ) {

Style in this file has spaces around operators ($i += 2), and not around
predicates
(if ($i > 1), while ($j < $i)).

r=shaver with those nits fixed, thanks for taking care of this for me!

Comment 4

[Justin Wood (:Callek)]

Attachment: Fix Review Nits

Shaver, thanks for checking in my first patch to get this stuff started, here
is the patch correcting the review nits, when this gets checked in, you can
resolve this bug. (or I can resolve)

Comment 5

[Justin Wood (:Callek)]

Attachment: Fix Review Nits (for real)

Grr, damn comment typo...Thanks to Colin on #bmo for pointing it out to me.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 191069 [details] [diff] [review]
Fix Review Nits (for real)

Dria poked at these review nit fixups for me, and comitted the file to cvs.