301675 - default value of size DOM attribute of HTMLSelectElement must be 0 when the HTML attribute is not there

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

See: <http://whatwg.org/specs/web-forms/current-work/#size>

That is consistent with what both Opera and IE have implemented.

Comment 1

[Boris Zbarsky [:bzbarsky]]

See
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLSelectElement.cpp#1542
(and the very  next line shows what you'd want to do for a default value of 0).

Comment 2

[Anne (:annevk)]

Attachment: patch #1

Something like this? Thanks for the point btw.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 190241 [details] [diff] [review]
patch #1

Indeed.  Want to get 1.8 approval and such too?  If so, let me know if/when you
need checkin.

Comment 4

[Anne (:annevk)]

Comment on attachment 190241 [details] [diff] [review]
patch #1

Trivial patch that make us a more conforming browser and more consistent with
both Opera and IE.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Checking in nsHTMLSelectElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLSelectElement.cpp,v  <-- 
nsHTMLSelectElement.cpp
new revision: 1.230; previous revision: 1.229
done

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This broke the tree since the patch didn't remove the old macro.  Timeless fixed it.