301676 - [PostgreSQL] Bugzilla::DB::Pg does not support using a local socket

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[ondrej]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

It is a common case to set $db_host = '' when I want to use local (UNIX) sockets
to connect to postgres server. It seems to me you have a bug in the connect()
that disallows using empty host. It leads checksetup.pl to output:
Can't connect to the database.
Error: could not translate host name "dbname=template1" to address: Name or
service not known
  Is your database installed and up and running?
  Do you havethe correct username and password selected in localconfig?
I think there is something like pg_connect("dbhost=$db_host dbname=template1
dbuser...");
You should check db_host for empty string and ommit the dbhost part.

Reproducible: Always

Steps to Reproduce:
1.edit localconfig file
2.set $db_host = '';
3.run ./checksetup.pl

Actual Results:  
Error: could not translate host name "dbname=template1" to address: Name or
service not known
  Is your database installed and up and running?
  Do you havethe correct username and password selected in localconfig?

Expected Results:  
Connect to database template1 using local socket.

Comment 1

[ondrej]

I have to mark this bug as a blocker as it prevents me from testing without
changing my server's configuration.
For those who need a workaround and have no problem with modifying their
configuration:
set $db_host = 'localhost';
and add this line to your pg_hba.conf
host $db_name $db_user 127.0.0.1/32 md5
host template1 $db_user 127.0.0.1/32 md5

replace variables with values from your config.

Comment 2

[Max Kanat-Alexander]

It's quite common to have to turn on listening on localhost for Pg. The docs
(which are forthcoming) specify that you have to do it. You have to change the
configuration anyhow, to allow access for the "bugs" user.

Bugzilla::DB::Pg does not currently use/support $db_sock, it's true.

That would be a valid enhancement for 2.22.

Comment 3

[ondrej]

It's quite common that admins don't want to allow listening on localhost in
Postgres.

Comment 4

[Max Kanat-Alexander]

Yeah. And I plan to implement the ability to do that for 2.22. The patch will go
on this bug, when it happens, most likely, so you can probably apply the patch
to a 2.20 installation if you desire.

Comment 5

[Frédéric Buclin]

We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.

Comment 6

[Max Kanat-Alexander]

I actually ought to fix this for 3.0.

Comment 7

[Emmanuel Seyman]

Taking

Comment 8

[Emmanuel Seyman]

Attachment: Patch to use the default local domain socket when no hostname is specified

Comment 9

[Emmanuel Seyman]

I didn't see what I was assigning to mkanat.
Sorry for the spam.

Comment 10

[Max Kanat-Alexander]

Comment on attachment 274061 [details] [diff] [review]
Patch to use the default local domain socket when no hostname is specified

Sure, works for me.

Comment 11

[Max Kanat-Alexander]

Comment on attachment 274061 [details] [diff] [review]
Patch to use the default local domain socket when no hostname is specified

>--- ./Bugzilla/DB/Pg.pm.301676	2007-07-26 22:12:24.000000000 +0200
>+    my $dsn = "DBI:Pg";
>+    $dsn .= ":dbname=$dbname";

  These two lines don't have to be separate, though. That can be fixed on checkin.

Comment 12

[Max Kanat-Alexander]

This is a small change for a useful gain, so it's OK for 3.0 also.

Comment 13

[Frédéric Buclin]

tip:

Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.24; previous revision: 1.23
done

3.0:

Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.23.2.1; previous revision: 1.23
done