301723 - vc6 can't compile cairo

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

c:/builds/debug-vc6-nopsdk/gfx/cairo/cairo/src/../../../../../../mozilla/gfx/cairo/cairo/src/cairo-win32-surface.c(635)
: error C2065: 'AC_SRC_ALPHA' : nichtdeklarierter Bezeichner

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

this is not an issue for similar defines in nsImageWin.h because AC_SRC_ALPHA is
unused there:
/gfx/src/windows/nsImageWin.cpp, line 628 -- blendFunction.AlphaFormat = 1; //
AC_SRC_ALPHA
/gfx/src/windows/nsImageWin.h, line 52 -- #define AC_SRC_ALPHA 0x01

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

also fixes bug 299686

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190136 [details] [diff] [review]
patch v2

allows compiling cairo on vc6 without installing a platform sdk. very low risk.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in gfx/cairo/alphablend.diff;
/cvsroot/mozilla/gfx/cairo/alphablend.diff,v  <--  alphablend.diff
new revision: 1.3; previous revision: 1.2
done
Checking in gfx/cairo/cairo/src/cairo-win32-surface.c;
/cvsroot/mozilla/gfx/cairo/cairo/src/cairo-win32-surface.c,v  <-- 
cairo-win32-surface.c
new revision: 1.2; previous revision: 1.1
done