vc6 can't compile cairo

RESOLVED FIXED in mozilla1.8beta4

Status

Core Graveyard
GFX
P1
normal
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8beta4
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

c:/builds/debug-vc6-nopsdk/gfx/cairo/cairo/src/../../../../../../mozilla/gfx/cairo/cairo/src/cairo-win32-surface.c(635)
: error C2065: 'AC_SRC_ALPHA' : nichtdeklarierter Bezeichner
this is not an issue for similar defines in nsImageWin.h because AC_SRC_ALPHA is
unused there:
/gfx/src/windows/nsImageWin.cpp, line 628 -- blendFunction.AlphaFormat = 1; //
AC_SRC_ALPHA
/gfx/src/windows/nsImageWin.h, line 52 -- #define AC_SRC_ALPHA 0x01
Created attachment 190136 [details] [diff] [review]
patch v2

also fixes bug 299686
Assignee: general → cbiesinger
Attachment #190133 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #190136 - Flags: review?(tor)
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta4

Updated

13 years ago
Attachment #190136 - Flags: review?(tor) → review+
Comment on attachment 190136 [details] [diff] [review]
patch v2

allows compiling cairo on vc6 without installing a platform sdk. very low risk.
Attachment #190136 - Flags: approval1.8b4?

Updated

13 years ago
Attachment #190136 - Flags: approval1.8b4? → approval1.8b4+
Checking in gfx/cairo/alphablend.diff;
/cvsroot/mozilla/gfx/cairo/alphablend.diff,v  <--  alphablend.diff
new revision: 1.3; previous revision: 1.2
done
Checking in gfx/cairo/cairo/src/cairo-win32-surface.c;
/cvsroot/mozilla/gfx/cairo/cairo/src/cairo-win32-surface.c,v  <-- 
cairo-win32-surface.c
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.