301742 - Accessibility problems in customize char encoding dialog

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

View -> Character Encoding -> Customize

Add and Remove buttons need mnemonics
Move Up and Move down buttons are tiny, undiscoverable, unfocusable and
untitled. I think we should use text buttons "Move &Up" and "Move &Down" so that
people know what they do and they're accessible.

Comment 1

[Aaron Leventhal]

Attachment: Lots of fixes, see comment

1. Don't clear selection when focus moves and then disable buttons based on
that, otherwise the buttons are always disabled when you try to tab to them
2. Add button titles and mnemonics
3. Add initial selection so focus in listboxes is visible
4. Remove hardcoding of dialog size so buttons fit
5. Associate labels with listbox controls

Comment 2

[Aaron Leventhal]

The posted patch fixes more than just the buttons.

Comment 3

[u60234]

The new entity definitions in customizeCharset.dtd don't seem to be included in
the patch.

Comment 4

[Aaron Leventhal]

Attachment: This time don't forget to post dtd changes with the patch

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 190362 [details] [diff] [review]
This time don't forget to post dtd changes with the patch

new patch will be forthcoming from Aaron :)

Comment 6

[Aaron Leventhal]

Attachment: Fix mconnor's issues, plus make Remove work on the multiple selection

Comment 7

[Aaron Leventhal]

Mike, you were saying something last night about needing icons for the buttons
and that you would put the code in a comment.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 190494 [details] [diff] [review]
Fix mconnor's issues, plus make Remove work on the multiple selection

r+a=me with the addition of icon attributes as discussed on IRC

Comment 9

[Aaron Leventhal]

Checking in toolkit/locales/en-US/chrome/global/customizeCharset.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd,v  <--
 customizeCharset.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/content/customizeCharset.js;
/cvsroot/mozilla/toolkit/content/customizeCharset.js,v  <--  customizeCharset.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/content/customizeCharset.xul;
/cvsroot/mozilla/toolkit/content/customizeCharset.xul,v  <--  customizeCharset.xul
new revision: 1.4; previous revision: 1.3
done

Comment 10

[Aaron Leventhal]

*** Bug 302354 has been marked as a duplicate of this bug. ***