301764 - In File size always set to "0" when editing local atttachments

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0

When you click on "edit a local attachment", the file size is always set to 0. 
That's because attachment.cgi does not use the Bugzilla::Bug::attachments()
routine that also returns the datasize.  Instead it always uses the
LENGTH(attachments.thedata) sql value. 

Reproducible: Always

Steps to Reproduce:

Comment 1

[A. Karl Kornel]

Suggest confirming.  I looked over the 2.20 code, and yes, it only checks the
size of the in-DB content (which is empty for bigfiles).

Comment 2

[Max Kanat-Alexander]

Confirmed per karl's comment.

Comment 3

[Frédéric Buclin]

Attachment.pm has been rewritten for 2.22 in bug 302669 and allows us to handle attachments much more easily. This is an easy fix, at least for 2.22.

Comment 4

[Frédéric Buclin]

Attachment: patch for 2.22, v1

use the great new Attachment.pm module.

Comment 5

[Frédéric Buclin]

Attachment: patch for 2.22, v1.1

s/thedata/data/

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 203786 [details] [diff] [review]
patch for 2.22, v1.1

Good stuff, no regressions. r=myk

Comment 7

[Frédéric Buclin]

I'm too lazy to backport it. Attachment objects do not exist in 2.20.

Comment 8

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.102; previous revision: 1.101
done
Checking in Bugzilla/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v  <--  Attachment.pm
new revision: 1.29; previous revision: 1.28
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.60; previous revision: 1.59
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.30; previous revision: 1.29
done