Top link to show next page of comments not usable

RESOLVED FIXED in 1.0

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: Mook, Assigned: alanjstr)

Tracking

unspecified
x86
Windows XP

Details

(URL)

Attachments

(2 attachments)

832 bytes, patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
: first-review+
Details | Diff | Splinter Review
812 bytes, patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
: first-review+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
The top "Next ยป" link in the all comments view is not usable; it is missing a
"&id=" in the URL, so the id is never transmitted (and a gigantic numpg is used).

The bottom link appears to be fine.

(Originally used FlashGot as an example, but mao was complaining that everyone
used his extension as a sample :p Price of popularity...)
(Assignee)

Comment 1

13 years ago
Oddly enough, the one at the bottom has it right.  Hooray for reused code.


(Reporter)

Comment 2

13 years ago
Created attachment 191082 [details] [diff] [review]
Make line 588 (top link) same as line 665 (bottom link) [checked in]

Possible patch - since I'm not running UMO, I can't exactly test ;)

This (hopefully) makes the top link the same as the bottom link.  Since I'm
just randomly locating stuff via LXR, this may be incorrect.
Attachment #191082 - Flags: first-review?(Bugzilla-alanjstrBugs)
Attachment #191082 - Flags: first-review?(Bugzilla-alanjstrBugs) → first-review+
(Reporter)

Comment 3

13 years ago
Created attachment 191083 [details] [diff] [review]
Once again, for themes [checked in]

Same thing, for themes (sorry for missing this the first time)

Makes line 601 match line 678.
Attachment #191083 - Flags: first-review+
Attachment #191082 - Attachment description: Make line 588 (top link) same as line 665 (bottom link) → Make line 588 (top link) same as line 665 (bottom link) [checked in]
Attachment #191083 - Attachment description: Once again, for themes → Once again, for themes [checked in]
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)
Component: Listings → Web Site
AMO BUGSPAM FOR QACONTACT FIX (FILTER ME)
QA Contact: listings → web-ui
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.