301870 - commands not updated when an item is de-selected in richlistbox

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Robert Strong (they/them - no direct email)]

The Extension Manager which uses a richlistbox used to have its commands updated
when a selected item is deselected so there are no items selected. This is a
recent regression... possibly bug 299947?

Comment 1

[Robert Strong (they/them - no direct email)]

To reproduce
Open the Extension Manager.
Select an item.
Deselect the item (e.g. ctrl+click the item or click a blank area in the
richlisbox).
Notice that the uninstall is still enabled.

Comment 2

[Doron Rosenberg (IBM)]

yup, my bad.  _fireOnSelect() is only called if selectedItem it set to
something.  clearSelection() should call as well.

Comment 3

[Doron Rosenberg (IBM)]

Attachment: patch

untested, build still going, but that should do it.

Comment 4

[Robert Strong (they/them - no direct email)]

Thanks doron - this patch works for me.

Comment 5

[Caleb]

*** Bug 302165 has been marked as a duplicate of this bug. ***

Comment 6

[Doron Rosenberg (IBM)]

fixed!