301963 - Software Installation Disabled notification has "undefined" as button text

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Tom Hessman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+

When you try to install an extension when Software Installation is disabled
(through Preferences), Firefox displays the notification bar that says that
Software Installation is disabled, and to click "Edit Options..." to enable it
and try again.  However, the text of the button is "undefined", not "Edit
Options..." on Mac OS X.  It does seem to be correct using Deer Park Alpha 2 on
Windows XP, but not on recent nightlies on Mac OS X.

I will attach a screenshot.

Reproducible: Always

Steps to Reproduce:
1. Disable Software Installation on the Content pane of Preferences.
2. Navigate to a page with an install link for installing an extension.
3. Click the install link (attempt to install the extension).

Actual Results:  
The notification bar appears, saying to click "Edit Options..." and try again,
but there is no such button.  The button text says "undefined".

Expected Results:  
The button text should be "Edit Options...", based on the text of the notification.

I didn't know which component this best fits under, since the notifcation bar
doesn't have its own component, and I wasn't sure if it's an Extension Manager
or not, so I apologize if this is in the wrong component.

Comment 1

[Tom Hessman]

Attachment: Screenshot of Software Installation Disabled Bar

Here is a screenshot of the bar with the "undefined" button, just to make
things a bit more clear.

Comment 2

[Adam Guthrie]

Can you reproduce this in a new profile?

Comment 3

[Tom Hessman]

Yes, I was able to reproduce this in a new profile.  I also tried with the site
on and off the whitelist.

Comment 4

[Ria Klaassen (not reading all bugmail)]

It happens here also. Randomly, 50% of the times I tried it, I see "Undefined"
and the other 50% "Edit Options". When I click "Undefined" the Options Window
shows up.
When I click OK, I get either an "Edit Options" buttons or another "Undefined"
button.
I see no pattern in the behaviour.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050725
Firefox/1.0+ ID:2005072504

Comment 5

[Ria Klaassen (not reading all bugmail)]

Regressed between ID 2005071310 and ID 2005071311.
Tried it 4 times on both build.

Comment 6

[Ria Klaassen (not reading all bugmail)]

8 times! :)

Comment 7

[Tom Hessman]

Well, I see it 100% of the time.

Also, I'm changing the title to describe the actual problem (Software
Installation , not Software Update)...oops. (c;=

Comment 8

[Adam Guthrie]

If this did regress when Ria said it did, it's probably from the checkin from
bug 287739.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser.js&rev1=1.453&rev2=1.454&root=/cvsroot

Comment 9

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050731 Firefox/1.0+

Should be: 

OS: MacOS X -> All
Hardware: Macintosh -> All
Summary: Software Installation Disabled notification has "undefined" as button
text on Mac -> Software Installation (xpinstall) Disabled notification has
"undefined" as button text

Comment 10

[Corinne Bordelon]

Josh -> can you take a look at this one for beta?

Comment 11

[Josh Aas]

-> Mano per IRC, thanks Mano

Comment 12

[Asaf Romano (gone)]

Not mac-specific, this is a regression from bug 287739.

Comment 13

[Asaf Romano (gone)]

Attachment: patch

fix typos

Comment 14

[Asaf Romano (gone)]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.469; previous revision: 1.468
done