301972 - "Save to Disk" option needs to be more clear

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Dan Fischbach]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+

I have a friend who is not very computer savvy. It occurred to me, that the
download dialog could be simplified a bit. When he went to download an exe, the
default, and only option is to "Save to disk". He said to me, "But I don't have
a disk". I thought to myself, "Maybe other people have this problem?" Why don't
we change it to just, "Save file" or just "Save" ala IE.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Pretty easy to change if the drivers see fit:
http://lxr.mozilla.org/mozilla/source/browser/locales/en-
US/chrome/browser/preferences/preferences.properties#74
http://lxr.mozilla.org/mozilla/source/mail/locales/en-
US/chrome/messenger/preferences/preferences.properties#44

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Gah, broken links:
http://lxr.mozilla.org/mozilla/source/browser/locales/en-
US/chrome/browser/preferences/preferences.properties#74
http://lxr.mozilla.org/mozilla/source/mail/locales/en-
US/chrome/messenger/preferences/preferences.properties#44

Comment 3

[Ryan VanderMeulen [:RyanVM]]

K, I quit. Sorry for the bugspam.

Comment 4

[Aaron Slunt]

Attachment: change "Save to disk" to "Save"

I agree with this. If firefox is now being aimed towards replacing IE, this
should be good. Changing "Save to disk" to "Save" will most certainly prevent
confusion, as IE uses "Save."

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 190359 [details] [diff] [review]
change "Save to disk" to "Save"

let's not monkey with this for now, I want to change the design of this dialog
in the 2.0 cycle, but changing stuff like this is unnecessary and not
necessarily clearer

Comment 6

[Worcester12345]

(In reply to comment #5)
> (From update of attachment 190359 [details] [diff] [review] [edit])
> let's not monkey with this for now, I want to change the design of this dialog
> in the 2.0 cycle, but changing stuff like this is unnecessary and not
> necessarily clearer
> 

For the cost of deleting two words, it would be worth it to get into the 1.1/1.5
release. Then deal with the other fix in 2.0. 

Comment 7

[Dan Fischbach]

Looks like to didn't happen.  Oh well.  ;-)  Anything on the Wiki concerning this, or any plans for 2.0?

Comment 8

[Mike Connor [:mconnor]]

Not a blocker, but tagged with uiwanted so it gets reviewed.

Comment 9

[u88484]

Donno exactly which one is wanted so I submitted a few patches. Just remember it has to go good with the question in the dialog. "What should &brandShortName; do with this file?" 

Save - No
Save to Disk - grandma does not know what a disk is
Save to Hard Drive - Maybe
Save to your default download location - My pick

Attaching patchs for last two entries in my list.

Comment 10

[u88484]

Attachment: Save to Hard Drive

Comment 11

[u88484]

Attachment: Save to default location

Comment 12

[Dan Fischbach]

Since I'm the original reporter of this bug, how about a "Save to my computer" option?

Comment 13

[Worcester12345]

The original "Save File" was the best idea.

Since there is a patch and all, this should be a no-brainer to be block (be fixed before) 2.0.

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 208554 [details] [diff] [review]
Save to Hard Drive

You can save to many things, hard drive is just one of them.

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 208555 [details] [diff] [review]
Save to default location

really wordy, and might not be right either, depending on the pref setting.

Comment 16

[u88484]

Any sugestions then or just leave well enough be? Are you still working on revamping the download manager, because I believe you mentioned something before in another bug which was about the same as this with renaming something about just waiting to see what you come up with later on.

Comment 17

[u88484]

Mike please see comment 16, thought you was on the CC list aswell.

Comment 18

[Mike Connor [:mconnor]]

This isn't a mustfix, but it might get fixed when we do the "clean up dialog text" pass.

Comment 19

[Adam Kennedy]

Just noting I had this scenario actually occur today.

Phone call from my not so technically savvy mother, who understands the basic (don't run attachments, say yes if windows of firefox asks to upgrade) confused.

her: "I'm trying to upgrade Firefox, and it has an option thing here with 'open with' sort of faded out, and 'Save to Disk' which looks like it is selected, and 'always do this action' sort of faded out"

me: "Yes, because it's a program, you have to save it first before you run it"

her: "So what do I do?"

me: "It's already select as Save to Disk, so click OK"

her: "But I don't have disks... sigh... so I have to go and buy some disks now"

me: "No no, it doesn't mean floppy disks"

her: "No, doesn't it mean disks... like a CD"

me: "Oh, no. It means the disk inside the computer"

her: "What disk inside the computer"

me: "It just means save to the computer, to the desktop"

her: "sigh... well why doesn't it just say that?"

and from there I walked her through the rest of saving and running the update.

It seems quite clear to me that "Disk" is quite unclear to non-technical people.

They know floppy disks and CD disks and maybe even DVD disks, but their computer is the box on the ground, or the box on the table, it doesn't look anything like a disk.

"Save to the computer" or even (in the special cases on Windows or Mac where the location to save to is something special) "Save to My Desktop" would seem much more sensible and make it easier to understand.

Comment 20

[Worcester12345]

Tell them they need more memory (frequent with Firefox), and they will say "I didn't know I was out of disk space already. The "browser for the people" should cater to "the people".

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

"Save File" is what you want here. If there's going to be a re-working of the DM, it will happen in a separate bug.

(removing uiwanted)

Comment 22

[Will]

Agreed with Mike. The functional part of the label is the "save"... you are keeping it rather than storing temporarily so "Save file" is semantically accurate as well as more (IMO) understandable. The alternative option still writes to disk anyway, just to a temporary folder.

Comment 23

[quark.green]

This bug was recently reported in the Ubuntu Launchpad bug #117260. My opinion is to change it to "Save file" which is more general and understandable. Is this going to changed in Firefox anytime soon?

Comment 24

[quark.green]

Dear Kurt, Would it be possible for you to make a patch for "Save file"? Then maybe we could get someone to apply the patch?

Comment 25

[AndrewM]

Is this going to make it for Firefox 3? To me, it seems like a good change to make things clearer.

Comment 26

[u88484]

Attachment: Changes "Save to disk" to "Save File"

Comment 27

[Reed Loden [:reed]]

Comment on attachment 280389 [details] [diff] [review]
Changes "Save to disk" to "Save File"

>-<!ENTITY  save.label                  "Save to Disk">
>+<!ENTITY  saveFile.label              "Save File">

You can't just rev the entity name without changing the file that actually uses the entity. In this case, the file is toolkit/mozapps/downloads/content/unknownContentType.xul, so you'll need to change save.label to saveFile.label in that file, too.

Comment 28

[u88484]

Attachment: Duh!

Sorry about that, this one should do.

Comment 29

[u88484]

Attachment: Last time

Damn sometime so simple and yet I kept screwing it up ;)  Last time, I promise unless the reviewer and/or beltzner wants it called something else.

Comment 30

[Shawn Wilsher :sdwilsh]

Comment on attachment 280397 [details] [diff] [review]
Last time

mconnor is incredibly busy.  Let's do the reviewer shuffle shall we?

Comment 31

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 280397 [details] [diff] [review]
Last time

Yes, let's. Guess who's back in town!

ui-r+

Comment 32

[Shawn Wilsher :sdwilsh]

Checking in toolkit/mozapps/downloads/content/unknownContentType.xul;
new revision: 1.22; previous revision: 1.21
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd;
new revision: 1.7; previous revision: 1.6