301986 - pthread_t cannot always be used as NSPR thread ID

Status: NEW

(NSPR :: NSPR, defect)

Description

[Mikhail T.]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.4; FreeBSD; X11; amd64) KHTML/3.4.1 (like Gecko)
Build Identifier: 

The thread_id is assumed, for some reason, to be a 32-bit value. This is not 
true on 64-bit systems. There is a special type for thread-ids and that is what 
should be used. 

Reproducible: Always

Comment 1

[Mikhail T.]

Attachment: Use pthread_t for thread-ids

Comment 2

[Wan-Teh Chang]

This is a real bug, but we can't use your proposed fix.

PR_GetThreadID is supposed to return a NSPR thread ID
that is a 32-bit unsigned integer and that may not be
related to the pthread or native thread ID.

The correct fix is for NSPR to create and maintain a
32-bit unsigned thread ID, rather than casting pthread_t
to PRUint32.

Because of this bug, PR_GetThreadID is not usable.  That's
one reason it is a "private" (but exported) function.

Comment 3

[Mikhail T.]

=The correct fix is for NSPR to create and maintain a 
32-bit unsigned thread ID 
 
Why can't it be a 64-bit value on 64-bit systems? 
 
=rather than casting pthread_t to PRUint32. 
 
My fix is not suggesting that. I suggest using pthread_t wherever thread ID is 
used. If need be, a PRThreadType or something can be introduced (which will be 
the same as pthread_t on pthread-using systems). 

Comment 4

[Mikhail T.]

This bug is 5 years old. What's holding it up? Why is anyone worried for ABI-compatibility (on 64-bit systems), that would be broken by the proposed change, if the existing code never worked on 64-bit systems anyway>

Comment 5

[Phoenix]

(In reply to Mikhail Teterin from comment #4)
> This bug is 5 years old. What's holding it up? Why is anyone worried for
> ABI-compatibility (on 64-bit systems), that would be broken by the proposed
> change, if the existing code never worked on 64-bit systems anyway>
I suppose, patch should be updated and review flag set as explained in https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch#Getting_reviews

Comment 6

[Jan Beich]

It should block bug 512076.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.