302039 - Locked profile dialog needs a better message

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Mike Connor [:mconnor]]

Spun off from bug 286355 comment 15

We need a better message so that users can do something useful when their
profile is locked.

beltzner's suggestion:

 Firefox is already running, but not responding. To open a new window, you
 must first close all Firefox processes, or restart your system.

Comment 1

[Benjamin Smedberg]

Attachment: Separate the unlocker and no-unlocker case for better verbiage, rev. 1

Comment 2

[Benjamin Smedberg]

Comment on attachment 190414 [details] [diff] [review]
Separate the unlocker and no-unlocker case for better verbiage, rev. 1

asa, did you mean to clear my approval request?

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 190414 [details] [diff] [review]
Separate the unlocker and no-unlocker case for better verbiage, rev. 1

no, I meant to plus it. sorry 'bout that.

Comment 4

[Benjamin Smedberg]

Fixed on trunk for 1.8b4

Comment 5

[Jesse Ruderman]

Shouldn't those |static const PRUnichar|s be null-terminated?

Comment 6

[Jesse Ruderman]

Now I don't see any message when I have trunk nightly A running and try to run
trunk nightly B.  Trunk nightly B bounces in the dock once and nothing else
happens.  In nightlies from a few days ago (before this change), I'd get the "is
already running, but is not responding" message.  Was that an intentional change?

Comment 7

[Benjamin Smedberg]

Yes! they should have been null-terminated, and I actually did that in a
different tree when testing and forgot to do it in my checkin tree. That error
would cause no dialog to appear.

Comment 8

[Darin Fisher]

While you're adding null terminators, how about wrapping long lines in
nsAppRunner.cpp at 80 chars?

Comment 9

[Jesse Ruderman]

The bustage fix worked.  I now see the (new) message after following the steps
in comment 6.