Closed Bug 302054 Opened 19 years ago Closed 18 years ago

Report broken website's privacy link is often invisible

Categories

(Other Applications Graveyard :: Reporter, defect)

Product:
Other Applications Graveyard
Component:
Reporter
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: pilgrim)

References

Details

(Keywords: access, fixed1.8.1)

Attachments

(2 files)

Screenshot of when the privacy link has focus. You can barely see top of the dotted outline below the email field. It didn't scroll into view as it should.
25.87 KB, image/gif
Details
Remove hardcoded width/height in reporterOverlay.js
2.25 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
You shouldn't have to scroll with the mouse to see it.

Even when you tab to it it does not become visible.
Attachment #190428 - Attachment is patch: false
Attachment #190428 - Attachment mime type: text/plain → image/gif
Attachment #190428 - Attachment description: Screenshot → Screenshot of when the privacy link has focus. You can barely see top of the dotted outline below the email field. It didn't scroll into view as it should.
Assignee: nobody → robert
(In reply to comment #1)
> Created an attachment (id=190428) [edit]
> Screenshot
> 
> This could be because I use a larger than normal font.


Nope, I see it on Linux too with default font-size.
OS: Windows XP → All
The problem is in reporterOverlay.js, which opens the reporter dialog with a hardcoded width and height (in pixels).  Removed those attributes and added min-width/min-height style to the reporter wizard.  Dialog still looks exactly the same with normal font theme but now resizes correctly in large-font or extra-large-font theme.
Assignee: robert → pilgrim
Status: NEW → ASSIGNED
Attachment #222877 - Flags: review?(mconnor)
Target Milestone: --- → Firefox 2 beta1
Attachment #222877 - Flags: review?(mconnor) → review?(bugs.mano)
Comment on attachment 222877 [details] [diff] [review]
Remove hardcoded width/height in reporterOverlay.js

Not a Reporter, ask Robert Accettura or mconnor for review.
Attachment #222877 - Flags: review?(bugs.mano)
Component: General → Reporter
Product: Firefox → Other Applications
Target Milestone: Firefox 2 beta1 → ---
QA Contact: general → xul-client
Not a Reporter _peer_ :)
Attachment #222877 - Flags: review?(mconnor)
Flags: blocking1.8.1?
Attachment #222877 - Flags: review?(mconnor) → review+
Comment on attachment 222877 [details] [diff] [review]
Remove hardcoded width/height in reporterOverlay.js

a=mconnor on behalf of drivers
Attachment #222877 - Flags: approval1.8.1+
Flags: blocking1.8.1? → blocking1.8.1+
mozilla/extensions/reporter/resources/content/reporter/reportWizard.xul 	1.10.2.1
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.js 	1.2.10.2
Keywords: fixed1.8.1
Hardware: PC → All
Whiteboard: [checkin needed]
Version: unspecified → 1.8 Branch
Is this bug now FIXED and no longer [checkin needed], or does the patch still need to land on trunk?
(In reply to comment #8)
> Is this bug now FIXED and no longer [checkin needed], or does the patch still
> need to land on trunk?

It still needs to land on the trunk, when I checked it into the branch the trunk was closed.
mozilla/extensions/reporter/resources/content/reporter/reportWizard.xul 1.12
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.js 1.7
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: