302074 - hint/help/alert order of precedence not being followed

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Stephen Pride]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050725 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050725 Firefox/1.0+

From the spec (8.3.4, 8.3.5, 8.3.6) - "If more than one source of message is
specified in [help/hint/alert], the order of precedence is: single node binding
attributes, linking attributes, inline text."  However, the order of precedence
is not always being followed by this processor.

Reproducible: Always

Comment 1

[Stephen Pride]

Attachment: testcase

First input field should generate "Instance Help Message".
Second input field should generate message with http://goggle.com content.
Third input field should generate "Inline Help Message".

Comment 2

[aaronr]

definitely a bug.  I'm going to put the patch in with the patch for 300255 since
I'm already in those files, though.  Please test this bug again when that patch
goes in.

Comment 3

[aaronr]

300255 might take a while longer.  I'll just move the precedence patch I did for
it over to this bug.

Comment 4

[aaronr]

Attachment: proposed fix

simple fix.  Just test for any single node binding attrs before looking for and
handling the src attr.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 190489 [details] [diff] [review]
proposed fix


>+  if (!hasBinding && !src.IsEmpty()) {

Actually, shouldn't it be enough to test !src.IsEmpty()

Comment 6

[aaronr]

(In reply to comment #5)
> (From update of attachment 190489 [details] [diff] [review] [edit])
> 
> >+  if (!hasBinding && !src.IsEmpty()) {
> 
> Actually, shouldn't it be enough to test !src.IsEmpty()
> 

That is essentially what was being done before my fix.  Problem is that binding
takes precedence, so shouldn't even look at the src attribute until we've
determined whether there is single node binding or not.

Comment 7

[Doron Rosenberg (IBM)]

checked in.