302075 - Add a link in mail start page to download dictionaries

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jérôme Schell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8b4) Gecko/20050720 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8b4) Gecko/20050720 Firefox/1.0+

Some dictionaries won't be distributed with Thunderbird due to licences problems.
So I think it should be a good thing to add a link to download dictionnaries in
the mail start page.

Two cases will occur:
- the dictionary is distributed with Thunderbird (compatible licence, for
exemple english dictionary): the link is pointing to
http://dictionaries.mozdev.org/ and tell the user that he can download
dictionaries for many languages from here.
- the dictionary is not distributed with Thunderbird (incompatible licence, for
exemple french): the link is pointing directly to the XPI of the language
dictionary and briefly explain how to install it.

I am attaching two screenshots for these two cases:
- The first in english for the generic case.
- The second in french with explanations saying "You can add french dictionary
by downloading and installing from Tools->Extensions menu this file" and "This
dictionary is distributed under the GNU/GPL Licence and then can not be
distributed with Thunderbird"


Reproducible: Always

Steps to Reproduce:

Comment 1

[Jérôme Schell]

Attachment: Screenshot in english

The english screenshot.

Comment 2

[Jérôme Schell]

Attachment: Screenshot in french

The french screenshot.

Comment 3

[Jérôme Schell]

Attachment: Patch to add the link

The patch that add the HTML and entity for that functionality.

Comment 4

[Benjamin Smedberg]

Attachment: Simpler patch

Comment 5

[Benjamin Smedberg]

Comment on attachment 190719 [details] [diff] [review]
Simpler patch

Self-approving based on very low risk.

Comment 6

[Benjamin Smedberg]

Fixed on trunk for 1.8b4

Comment 7

[u60234]

Could we have a localization note like
+<!-- Localization-specific information, i.e. how to download a dictionary. -->
in start.dtd also? So the localizers know what to do with the "startpage.extra"
entity.

Comment 8

[Grey Nicholson (they/them)]

Should the link not go to
http://www.mozilla.org/products/thunderbird/dictionaries.html ?

Comment 9

[Benjamin Smedberg]

That page is not localized, so, no.

Comment 10

[Oliver Saier]

I must be missing something because I haven't noticed any change in the start
page (TB 2005073005 auto-updated exe build)

Comment 11

[Benjamin Smedberg]

That's correct, there is no text in English because we pre-ship the English
dictionary. This entity is only for use by locales which cannot ship a localized
dictionary for licensing reasons.

Comment 12

[Ville Pohjanheimo (inactive)]

Suggest reopening as the new entity is separate of other content...

In a new trunk build (30.07.2005 14:35:00) the start.xhtml has the the new
entity  "&startpage.extra; outside the "indent" div. This forces the localizer
to either specify his own separate styling for the content of "&startpage.extra;
or to start a new div with id="indent" (which is an incorrect double id=""
entry) which has the effect of repeating the background image (Thunderbird logo).

Moving the entity a couple of lines up, so that it's inside the div, will fix
the issue.

(I'd also file a patch myself, but that would require me to DL the source tree
AFAIK, so I'll pass. :( )

Comment 13

[Jérôme Schell]

Attachment: Patch to move the new entity in the <div>

This is the patch to move the new extra entity inside the <div> section and
keep the right formatting for that section.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 191888 [details] [diff] [review]
Patch to move the new entity in the <div>

Please land these changes. We're not in the l10n freeze yet.