Closed
Bug 302097
Opened 19 years ago
Closed 19 years ago
E4X: Function.prototype.toString incorrectly quotes {} attribute values
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
shaver
:
review+
shaver
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Given the function:
function f(k) {
return <xml k={k}/>;
}
f.toString() returns
function f(k) {
return <xml k="{k}"/>
}
which is incorrect.
|
Assignee | |
Comment 1•19 years ago
|
||
Once bug 301692 is checked in, I think I'll be able to fix this, also.
Assignee: general → mrbkap
|
|
Assignee | |
Comment 2•19 years ago
|
||
This simple (hah! A simple patch in the decompiler!) patch remembers whether
the attribute value wants to be quoted or not.
Attachment #190606 -
Flags: review?(shaver)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•19 years ago
|
||
Comment on attachment 190606 [details] [diff] [review]
Don't quote every attribute
r+a=shaver.
Attachment #190606 -
Flags: review?(shaver)
Attachment #190606 -
Flags: review+
Attachment #190606 -
Flags: approval1.8b4+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Flags: testcase?
|
|
||
Comment 5•19 years ago
|
||
Checking in regress-302097.js;
/cvsroot/mozilla/js/tests/e4x/TypeConversion/regress-302097.js,v <--
regress-302097.js
initial revision: 1.1
Flags: testcase? → testcase+
You need to log in
before you can comment on or make changes to this bug.
Description
•