302173 - JS engine doesn't work on PPC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

The following has been observed with Firefox 1.0.6 and Mozilla 1.7.10
on ppc architecture:

- Firefox doesn't start at all
- Mozilla starts and shows its userinterface but nothing can be done besides
  navigating through the interface (no action possible)

After some investigation I've found that the stack direction is calculated wrong
in jscpucfg.c if it's compiled with gcc 3.3.3 and -O2.
That happens because the function StackGrowthDirection is inlined and therefore
the behaviour is undefined.

I propose the following patch.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: forbid inlining for gcc

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

What versions of gcc support noline?  I think we probably need a version test
here.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

AFAIK the attribute is supported since gcc 3.1. Earlier versions just ignore it.

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

r+a=shaver

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

checked in