JS engine doesn't work on PPC

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: wolfiR, Assigned: wolfiR)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
The following has been observed with Firefox 1.0.6 and Mozilla 1.7.10
on ppc architecture:

- Firefox doesn't start at all
- Mozilla starts and shows its userinterface but nothing can be done besides
  navigating through the interface (no action possible)

After some investigation I've found that the stack direction is calculated wrong
in jscpucfg.c if it's compiled with gcc 3.3.3 and -O2.
That happens because the function StackGrowthDirection is inlined and therefore
the behaviour is undefined.

I propose the following patch.
(Assignee)

Comment 1

13 years ago
Created attachment 190526 [details] [diff] [review]
forbid inlining for gcc
Assignee: general → mozilla
Status: NEW → ASSIGNED
Attachment #190526 - Flags: superreview?(shaver)
Attachment #190526 - Flags: review?(shaver)
Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

What versions of gcc support noline?  I think we probably need a version test
here.
Attachment #190526 - Flags: superreview?(shaver)
Attachment #190526 - Flags: superreview-
Attachment #190526 - Flags: review?(shaver)
Attachment #190526 - Flags: review-
(Assignee)

Comment 3

13 years ago
AFAIK the attribute is supported since gcc 3.1. Earlier versions just ignore it.

Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

r+a=shaver
Attachment #190526 - Flags: superreview-
Attachment #190526 - Flags: review-
Attachment #190526 - Flags: review+
Attachment #190526 - Flags: approval1.8b4+
(Assignee)

Comment 5

13 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Flags: testcase-
You need to log in before you can comment on or make changes to this bug.