302260 - ASSERTION: update-band called late: 'psd->mX == psd->mLeftEdge'

Status: RESOLVED WORKSFORME

(Core :: Layout: Block and Inline, defect)

Description

[Bob Clary [:bc] (inactive)]

I just recently began seeing the following assertion on the branch _and_ trunk
on www.aol.com. They have recently redesigned their homepage, so the appearance
of the assertion may just be due to changed content and not to changes in the
browser.

ASSERTION: update-band called late: 'psd->mX == psd->mLeftEdge', file
c:/work/mozilla/builds/ff/trunk-test/mozilla/layout/generic/nsLineLayout.cpp,
line 387

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: More minimal testcase

The lack of whitespace before the <span> is key here -- it needs to be the first thing in its block.

When the assert fires, mLeftEdge == 0 and mX is equal to the text-indent value...

I'm not really sure what the right fix would be here, if nothing else because I'm not sure what mX and mLeftEdge are (that is, how they differ).  Some docs in the PerSpanData struct definition would be nice.  ;)

Comment 3

[Jesse Ruderman]

Still happens on trunk.

Comment 4

[Jesse Ruderman]

This assertion was removed in the following changeset:

changeset:   15299:5c30c5953d22
user:        Robert O'Callahan <[e-mail]>
date:        Wed Jun 11 11:53:22 2008 +1200
summary:     Allow floats to be placed on the current line even after nonzero-width inline content has been placed. Fixes an Acid3 layout bug. r+sr=dbaron

The testcase doesn't trigger any other assertions, so I added it as a crashtest.