302264 - fix soon-to-be-fatal warning: bad access to protected variable

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Josh Aas]

BrowserWindowController.mm: In function 'int TabBarVisiblePrefChangedCallback(const char*, void*)':
BrowserWindowController.mm:3503: warning: instance variable 'mTabBrowser' is @protected; this will be a 
hard error in the future

Comment 1

[Josh Aas]

Attachment: fix v1.0

This got rid of the warning, I'm on x86 now and can test to see if the patch
really works on PPC soon. Not requesting review until I test, but its easy so
feel free to review if you want.

Comment 2

[Josh Aas]

Of course, we'd actually delete the bad replaced line instead of commenting it out if we were going to land 
that patch :)

Comment 3

[Mark Mentovai]

Comment on attachment 190631 [details] [diff] [review]
fix v1.0

r=mark, why not just whack the commented line?

Comment 4

[Josh Aas]

landed - I guess mark just didn't see my comment right before his :)