302352 - reuse blank foreground tab when opening external links

Status: RESOLVED DUPLICATE of bug 320989

(Firefox :: Tabbed Browser, defect)

Description

[(not currently active) Ted Mielczarek]

If an external link would open a new tab, but the foreground tab is about:blank,
it should be reused instead of opening a new tab.

Patch in a minute.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Reuse blank foreground tab instead of new tab

Pretty trivial, if the current tab is about:blank and we're loading a url in a
new tab from an external source, just reuse the existing tab.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 190720 [details] [diff] [review]
Reuse blank foreground tab instead of new tab

Adding to mconnor's insurmountable review queue.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 190720 [details] [diff] [review]
Reuse blank foreground tab instead of new tab

thought I marked this, guess I just talked on IRC.

We should only reuse if its the last tab.  Also,
gBrowser.selectedBrowser.currentURI.spec === "about:blank" works too.

Comment 4

[Jesse Ruderman]

If a script calls window.open("about:blank") and then adds to it using DOM 2
functions, will this code still treat it as a blank tab?

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to comment #4)
> If a script calls window.open("about:blank") and then adds to it using DOM 2
> functions, will this code still treat it as a blank tab?

Jesse: do you have a working example I can test this with?

Comment 6

[Jesse Ruderman]

javascript:x=window.open("about:blank"); setTimeout(function() { x.document.body.appendChild(x.document.createTextNode("foo")); }, 1000); void 0

Comment 7

[Adam Guthrie]

*** Bug 339005 has been marked as a duplicate of this bug. ***

Comment 8

[(not currently active) Ted Mielczarek]

Not that there's any more activity over on that other bug, but mconnor probably has a better chance of fixing this than I do currently.

*** This bug has been marked as a duplicate of 320989 ***