302357 - some .cgi files ignore Param(shutdownhtml) in 2.19.x and 2.20rc1

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

In 2.20rc1 and older, Param(shutdownhtml) is checked in CGI.pl. But some .cgi
files do not require CGI.pl meaning that this parameter is ignored. The affected
files are:

2.18.3:

showattachment.cgi, testagent.cgi

2.20rc1:

showattachment.cgi, testagent.cgi, editclassifications.cgi, editvalues.cgi

The first two files are not a problem, because testagent.cgi has no relation
with Bugzilla; it is only used to test Apache. And showattachment.cgi simply
redirects to attachment.cgi which requires CGI.pl and will then take this
parameter into account.

In other words, 2.18.x is not affected, and only editclassifications.cgi and
editvalues.cgi in 2.19.x and 2.20rc1 are concerned.

2.21+ is not affected because this check has been moved into Bugzilla.pm.

Comment 1

[Frédéric Buclin]

Attachment: patch for 2.20 only, v1

add require "CGI.pl";

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 190725 [details] [diff] [review]
patch for 2.20 only, v1

Tested to be working. Both editvalues and editvalues seem to work and both are
now correctly shutdown.

Comment 3

[Frédéric Buclin]

Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <-- 
editclassifications.cgi
new revision: 1.12.2.1; previous revision: 1.12
done
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.3.2.2; previous revision: 1.3.2.1
done