302398 - print dialog if pages selection empty but select all pages print button still disabled

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Rob Hudson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6

On any page select File -> Print...
Under "Print Range" select "Pages" and leave either the "from" and/or "to" box
empty.  Now change your mind and select "All Pages".  The Print button is still
disabled.

In my case I printed page 1 to 1 as a test to see if an article would print ok.
 It looked fine.  My hope was printing from 2 to "" (empty) would print from 2
to the end of the article since I do not know how many pages it will be from
this dialog box.

I would suggest as an enhancement to either:
1.  Display total number of pages so one can select a certain page number to the
end of the document.
2.  Allow the "to" box to be empty meaning to print to the end.

Reproducible: Always

Comment 1

[Adam Guthrie]

Attachment: patch v1.0

When the user selects a different option (all pages or selection), re-enable
the print button, and when the user reselects the page range option, make sure
a valid page range is entered before enabling the print button again.

Comment 2

[Adam Guthrie]

Attachment: patch for both toolkit and xpfe

Comment 3

[[e-mail]]

Comment on attachment 190789 [details] [diff] [review]
patch for both toolkit and xpfe

>+    checkInteger(dialog.frompageInput);
>+    checkInteger(dialog.topageInput);
Unfortunately if dialog.frompageInput is invalid but dialog.topageInput is
valid then it will still enable the OK button. In fact the whole
enabling/disabling scenario is busted and needs a rewrite.

Comment 4

[:Hb]

Firefox 3.5 has now only input field for the page range and no more separate ones.

Print button becomes aviable after a printer is selected.