302407 - whine.pl can cause an "already_locked" error with Bugzilla::User.pm

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

whine.pl needs to pass the "tables_locked_for_derive_groups" flag when
creating a new Bugzilla::User() object.  Otherwise if Bugzilla::User
needs to call the derive_groups() routine, you'll get this error message.

  Attempted to lock a table without releasing previous lock first:
    Tables already locked:
        whine_schedules WRITE, whine_events READ, profiles WRITE, groups READ,
group_group_map READ, user_group_map WRITE
    Tables requesting locking:
        profiles WRITE, user_group_map WRITE, group_group_map READ, groups READ



Reproducible: Always

Comment 1

[Albert Ting]

Attachment: v1

suggested patch.

Comment 2

[:glob ✱]

*** This bug has been marked as a duplicate of 299211 ***

Comment 3

[Albert Ting]

I'm sorry, but I don't believe this is a duplicate.  There are two other
Bugzilla::User->new() calls.  Bug 299211 only fixed 1 out of the 3.

Comment 4

[:glob ✱]

ah, indeed. sorry about that.

Comment 5

[Albert Ting]

(In reply to comment #4)
> ah, indeed. sorry about that.

No problem.  And for the record, I wrote the patch because I actualy hit the bug
in my setup.  It's an odd case, but it did occur. :)

Comment 6

[Max Kanat-Alexander]

No, if it's just an odd case, I don't want to block on it. I think we handled
the common case.

However, it'd be worthwhile for a landing on the 2.20 branch at some point.

Comment 7

[Albert Ting]

> No, if it's just an odd case, I don't want to block on it. I think we handled
> the common case.

Yes, but note that it stopped all of my whines to work as whine.pl aborted
immediately.  In my situation, I believe it occurred after I disabled just 1
person's account.  But will leave it up to you when you want to check this in.

Comment 8

[Joel Peshkin]

Comment on attachment 190771 [details] [diff] [review]
v1

Groups are no longer derived on user object creation.  (only on regexp or login
edit)

Comment 9

[Joel Peshkin]

Comment on attachment 190771 [details] [diff] [review]
v1

oh wait....  this would effect 2.20

Comment 10

[Joel Peshkin]

Checked in for Albert on 2.20 branch only.

Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.13.2.1; previous revision: 1.13
done

Comment 11

[Albert Ting]

(In reply to comment #10)
> Checked in for Albert on 2.20 branch only.

Thanks Joel!