302438 - Leaking nsFloatCache objects when image is aligned

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk

STEPS TO REPRODUCE:  Load testcase URL.  Reload a couple of times. Leak one
nsFloatCache per reload.

NOTES: If I use a div, span, or image without a URI, I don't leak.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that this leaks on various mozilla.org pages...

Comment 2

[Asa Dotzler [:asa]]

not a blocker but if there's a simple fix we should take it.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Worksforme.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm... I can't reproduce it anymore either...

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, I think I'm seeing this again -- this is the cause of the latest refcount
leak jump on the Firefox trunk balsa build (the Oct 16 jump).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er... maybe not.  This testcase still doesn't seem to leak... I'll try to
minimize the page that does.  :(

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK, reopening again.  It looks like align="left" leaks, but style="float:left"
does not.  I have no idea how that happens.  :(

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

So we leak a float cache any time we remove a float from a line...

The assertions and extra logging are cosmetic; the nsBlockReflowState fixes
another leak, as far as I can tell.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 10

[Bernard Alleysson]

As a fixed memory leak bug, could this be considered for 1.8rc2 ?

Comment 11

[Boris Zbarsky [:bzbarsky]]

This isn't a big leak, really, and I just don't think it's worth the risk of changes to 1.8 at this point.

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 68805 has been marked as a duplicate of this bug. ***