302444 - include unpackaged files in package lists

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

We are currently building building quite a few files that don't actually make it
into packages.  Among them is xulappinfo.{js,xpt}, so Chatzilla still reports
"SeaMonkey rv:1.8b4/20050726" instead of "Seamonkey 1.0a/20050726".

Comment 1

[Andrew Schultz]

Attachment: patch

this is linux-only.  This is based on a patch in wolfiR's seamonkey SRPM, minus
some extra stuff.  I left in SVG/canvas as extras don't actually break anything
(it complains during packaging, and movoes on) and that will hopefully be
included eventually anyway.

Windows also needs to get patched (it at least needs xulappinfo.*), but I'll
leave that to someone who can verify the files.

Comment 2

[[e-mail]]

Comment on attachment 190806 [details] [diff] [review]
patch

What are jsconsole.js and nsResetPrefs.js? Also I don't think we need to
package .manifest files.

Comment 3

[Robert Kaiser]

Agreeing that we need to have correct packages for 1.0 Alpha.
Do we still package the files bug 265492 was about? If so, we should remove them
from installer as well.

And, of course, we need those changes in files for other platforms as well.

Comment 4

[Andrew Schultz]

jsconsole.js should be jsconsole.xpt (it's correct in packages-unix and wrong in
packages-static-unix)

http://lxr.mozilla.org/seamonkey/source/xpfe/components/resetPref/nsResetPref.js#38

the .manifest can go.

Comment 5

[Mark Banner (:standard8)]

Due to recent changes in LDAP address books, we need to ensure that we include
bin/components/nsAbLDAPAttributeMap.js under the mail section. If we don't have
this, LDAP won't work...

Comment 6

[Robert Kaiser]

Comment on attachment 190806 [details] [diff] [review]
patch

>+bin/components/libsystem-pref.so
>+bin/components/htmlparser.xpt
>+bin/components/lwbrk.xpt
>+bin/components/nsInterfaceInfoToIDL.js
>+bin/components/nsResetPref.js
>+bin/components/nsUpdateNotifier.js
>+bin/components/plugin.xpt
>+bin/components/prefetch.xpt
>+bin/components/imgicon.xpt
>+bin/components/libimgicon.so

Are all those needed? Or are some of those testing files that need not be
installed anyways?

>-bin/defaults/pref/inspector.js

Why do you remove that one?

Comment 7

[Robert Kaiser]

Attachment: patch v2: all platforms

This is a patch that should include all platforms (unix, win, os2) we have.
I intentionally didn't include the files I asked about in the last comment in
the gre-based windows installer files, as I don't know where they would belong
(gre or seamonkey)...

ajschult, feel free to take over any work that is still needed again, I just
want to drive this forward so that we get ready for Alpha...

Comment 8

[Andrew Schultz]

> Are all those needed? Or are some of those testing files that need not be
> installed anyways?

They're all included in the tarball, except the *imgicon* files.  That might be
a subtle difference in build options.  I think files in the tarball (or zip)
should be packaged unless we know we don't need them (like stuff in res/), not
only if we know we need them.  We've been going without the XULAppInfo stuff
since it was checked in and nobody noticed.

AFAIK, none of the files in my patch are used for any tests.

> >-bin/defaults/pref/inspector.js
> 
> Why do you remove that one?

I don't know.  It looks like it should stay in the package list.

Comment 9

[[e-mail]]

Comment on attachment 192843 [details] [diff] [review]
patch v2: all platforms

>+bin/chrome/svg.jar
I don't see it in my Windows svg build, where does this file come from?

>Index: mozilla/xpinstall/packager/packages-os2

>+bin/components/libimgicon.so
A .so file on OS/2?

>Index: mozilla/xpinstall/packager/packages-static-unix

>-bin/defaults/pref/inspector.js
>-bin/res/inspector/viewer-registry.rdf
>+bbin/defaults/pref/inspector.js
>+in/res/inspector/viewer-registry.rdf
Typo?

>Index: mozilla/xpinstall/packager/packages-unix

>-bin/chrome/inspector.jar
> bin/defaults/pref/inspector.js
>+bin/chrome/inspector.jar
Is this the order that the other packages use?

Comment 10

[Robert Kaiser]

(In reply to comment #9)
> >+bin/chrome/svg.jar
> I don't see it in my Windows svg build, where does this file come from?

Hmm, I did copy the line from ajschult, but I don't even find it in my Linux svg
builds, it probably should be removed.

> >+bin/components/libimgicon.so
> A .so file on OS/2?

I already had fixed it locally, it should be the .dll instead. I think the same
had happened on static-windows...

> >+bbin/defaults/pref/inspector.js
> >+in/res/inspector/viewer-registry.rdf
> Typo?

Yes, paste error. Fixed locally.

> >-bin/chrome/inspector.jar
> > bin/defaults/pref/inspector.js
> >+bin/chrome/inspector.jar
> Is this the order that the other packages use?

No, again a paste-error. Also fixed locally.

Comment 11

[Robert Kaiser]

Attachment: patch v2.1: address comments

This patch contains correct changes for GRE installer as well (thanks to biesi
for some help with that) and adresses all comments made so far.
From what I see, this looks ready to go in - I haven't tested it myself yet, so
I'd be glad to hear from people who are building and using installers if it
works out correctly.
Final real testing will be tinderboxen and QA people in this case, I assume...

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

FWIW, this bug is probably the reason why canvas isn't working, at least in
installer builds.

Comment 13

[Robert Kaiser]

(In reply to comment #12)
> FWIW, this bug is probably the reason why canvas isn't working, at least in
> installer builds.

Sure it doesn't work in installer builds as it's not included in the packaging
lists yet, but this patch should fix that as well...

Comment 14

[Robert Kaiser]

Comment on attachment 193172 [details] [diff] [review]
patch v2.1: address comments

requesting approval for branch checkin: SeaMonkey-only fix for installer
packages to include a bunch of missing files

Comment 15

[Robert Kaiser]

checked into trunk, keeping open for branch checkin

Comment 16

[Robert Kaiser]

Checked in on both trunk and 1.8 branch.

Comment 17

[mv_van_rantwijk]

FYI: dom_loadsave.xpt is still missing, see bug 310637