302462 - Support :valid, :invalid, :out-of-range, and :in-range pseudoclasses

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Allan Beaufour]

In bug 271720 there was an agreement on:
"So should we just have valid/in-range always be true and invalid/out-of-range
false for HTML elements?  And leave an XXX: for whoever implements Web Forms in
the future?"
(https://bugzilla.mozilla.org/show_bug.cgi?id=271720#c75)

Comment 1

[Allan Beaufour]

Attachment: Patch

Here's a patch that implements the above, but I just looked at CSS3UI again,
and it actually says:
"An element that lacks data range limits or is not a form control is neither
:in-range nor :out-of-range."

?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, that's what dbaron said in bug 271720 as well.

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> Yeah, that's what dbaron said in bug 271720 as well.

Yes, aparently I cannot read... so what's the plan? Should we just add them to
CSS, so we can use them in XForms?

Comment 4

[Boris Zbarsky [:bzbarsky]]

That sounds like the best plan for now, yes.

Comment 5

[Allan Beaufour]

Attachment: Patch wo HTML handling

(In reply to comment #4)
> That sounds like the best plan for now, yes.

Ok, here's a patch for that then.

Comment 6

[Allan Beaufour]

Attachment: Updated to current cvs

Comment 7

[Allan Beaufour]

Attachment: ok ok, let's only check :target once

Comment 8

[Allan Beaufour]

Attachment: oh my

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.9a

Comment 10

[Mike Schroepfer]

Comment on attachment 194360 [details] [diff] [review]
oh my

Too close to beta1 - will have to wait until the next release.

Comment 11

[aaronr]

(In reply to comment #10)
> (From update of attachment 194360 [details] [diff] [review] [edit])
> Too close to beta1 - will have to wait until the next release.	 
> 

Next release, as in 2006/2007?  Or next beta as in October?

Comment 12

[Boris Zbarsky [:bzbarsky]]

For what it's worth, this is a very very safe patch.  If this is badly needed by
XForms, I would be quite comfortable taking this after beta1.

Comment 13

[Doron Rosenberg (IBM)]

We would really like this, and have customers who have requested pseudo classes.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 194360 [details] [diff] [review]
oh my

setting the approval request for doron (I think he's requesting approval to
land in beta2.)

Comment 15

[Doron Rosenberg (IBM)]

checked into branch (forgot to add r=/a= in the comment, oops)