302479 - Some pref panels still with missing/incorrect accesskeys

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

There are still some other pref panels with missing/incorrect accesskeys e.g.:
Navigator (on Windows)
Helper Applications
Smart Browsing
Scripts & Plugins (perhaps)
Software Installation (case changes only e->E, c->C)

This has been spun off from bug 289444

Comment 1

[Gérard Talbot]

Ian, I just noticed this bug after filing bug 306921: it covers 10 clearly
defined preferences window situations where the accesskey is wrongly chosen or
not the best.

Comment 2

[Giacomo Magnini]

I have all of the changes done here locally, even for the other bug, but I won't
upload the diff's untill bug 289444 gets closed since I have a single tree
building and I don't have the time to prepare tons of different patches. While
fixing reported things, I've cleared indentation on a few files and changed
another small bunch of accesskeys which were not very readable (like t or r) or
weren't using capitols where needed.
The only missing thing is the addition of accesskeys to the list of checkable
scripts inside the scripts & plugins panel...

Comment 3

[Gérard Talbot]

> I have all of the changes done here locally, even for the other bug, 

Ok, Giacomo. I am marking bug 306921 as dependent on this bug ... unless you
want bug 306921 to be resolved as duplicate...

Comment 4

[Giacomo Magnini]

(In reply to comment #3)
> > I have all of the changes done here locally, even for the other bug, 
> 
> Ok, Giacomo. I am marking bug 306921 as dependent on this bug ... unless you
> want bug 306921 to be resolved as duplicate...

I would like to, since I can't even comment on that bug, BUT, since it's related
to a FX bug, leave that as it is now. Thanks for adding the dependency! Nice to
talk to you again Gérard! ;)

Comment 5

[Giacomo Magnini]

Attachment: Here it comes, for a first review, in case I forgot something...

I've included all of IanN suggestions but the last ones (for point 10 on the
other bug). A few files had their indentation fixed too. Please check
carefully!

Comment 6

[Ian Neal]

Comment on attachment 195616 [details] [diff] [review]
Here it comes, for a first review, in case I forgot something...

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-smart_browsing.dtd
>===================================================================
>@@ -9,21 +9,22 @@
> <!ENTITY moreInformation.label                 "More Information...">
> <!ENTITY moreInformation.accesskey             "M">
> <!--LOCALIZATION NOTE (enableKeyCheck.label): Do not translate 'Internet Keywords' -->
> <!ENTITY keywordsEnabled.label                 "Enable Internet Keywords">
> <!ENTITY keywordsEnabled.accesskey             "k">
Change to K or E

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-search.dtd
>===================================================================
>@@ -1,20 +1,20 @@
>+<!ENTITY  pref.search.title                "Internet Search">
>+<!ENTITY  legendHeader                     "Default Search Engine">
>+<!ENTITY  defaultSearchEngine.label        "Search using:">
>+<!ENTITY  defaultSearchEngine.accesskey    "u">
Perhaps change to S?

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-mousewheel.dtd
>===================================================================
>@@ -1,29 +1,29 @@
.
.
.
>+<!ENTITY scrollPgUpPgDn.label            "Scroll a page up or a page down">
>+<!ENTITY scrollPgUpPgDn.accesskey        "a">
>+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
>+<!ENTITY scrollPgLtPgRt.accesskey        "o">
>+<!ENTITY history.label                   "Move back and forward in the browsing history">
>+<!ENTITY history.accesskey               "m">
Change to M?

r= with those changes

Comment 7

[Giacomo Magnini]

Attachment: Updated patch

Version 2:
- fixed nits
- removed unused entities in winhooks
- changed a comment to better reflect current status in winhooks

Comment 8

[Giacomo Magnini]

Attachment: Another update

V3, per IRC discussion:
- fixed some accesskeys
- removed cruft and better names in pref-advanced.dtd/xul

Comment 9

[Giacomo Magnini]

Attachment: MailNews part to finish off bug 306921

Comment 10

[Giacomo Magnini]

Attachment: Again...

Comment 11

[Giacomo Magnini]

Attachment: MailNews V.2, this should be the one

Changed a few accesskeys, added a few comments to mailPrefsOverlay.dtd to
explain where the entities are used, some caption lovin'...

Comment 12

[Giacomo Magnini]

Attachment: MailNews part V2 (-w version for Mnyromyr)

Comment 13

[Karsten Düsterloh]

Comment on attachment 196166 [details] [diff] [review]
MailNews V.2, this should be the one

>Index: locale/en-US/mailPrefsOverlay.dtd
>===================================================================
>+<!-- These are added to the Advanced - Scripts & Plug-ins panel -->

This panel still needs som lovin':
1. 'Navigato_r_' --> but 'N' isn't used?!
2. 'Allow Scripts to' lacks an accesskey (to get the focus into the list)

> <!ENTITY enbPluginCheckMailNews.label     "Mail &amp; Newsgroups">
>-<!ENTITY enbPluginCheckMailNews.accesskey "p">
>+<!ENTITY enbPluginCheckMailNews.accesskey "a">

I'd suggest taking 'A' for 2. and something else here, or maybe 'S' for 2.?

>Index: locale/en-US/pref-mailnews.dtd
>===================================================================
>-<!ENTITY nextButton.accesskey             "x">
...
>+<!ENTITY nextButton.accesskey        "N">

This is bad, because we now have 'N' twice on this panel!
(See
<http://lxr.mozilla.org/mozilla/source/mailnews/mapi/resources/locale/en-US/pre
f-mailnewsOverlay.dtd>.)

>Index: locale/en-US/pref-viewing_messages.dtd
>===================================================================
>+<!ENTITY displayPlainText.caption         "When displaying plain text messages">

This isn't a suitable text for a groupbox caption, imo.
How about just "Plain text messages"?
And keep in mind possible collisions with bug 292688. ;-)

> Index: locale/en-US/pref-notifications.dtd
> ===================================================================
> -<!ENTITY newMessagesArrive.label          "When new messages arrive:">
> +<!ENTITY newMessagesArrive.caption   "When new messages arrive:">

Groupbox captions shouldn't end in ':' - and actually the groupbox is quite
superfluous here anyway. But for consistency, just try to mimic the other
panels:

+- Notifications ------------------------+
| When new messages arrive:		 |
...

Comment 14

[Karsten Düsterloh]

(In reply to comment #13)
> And keep in mind possible collisions with bug 292688. ;-)

Oops, bug 292668, of course. :-|

Comment 15

[[e-mail]]

Comment on attachment 196154 [details] [diff] [review]
Again...

>+<!ENTITY enbJavaCheck.label         "Enable Java">
>+<!ENTITY enbJavaCheck.accesskey     "E">
>+<!ENTITY showHideTooltips.label                 "Show Tooltips">
>+<!ENTITY showHideTooltips.accesskey             "S">
>+<!ENTITY useSiteIcons.label                     "Show Web Site Icons">
>+<!ENTITY useSiteIcons.accesskey                 "W">
>+<!ENTITY useSmoothScroll.label                  "Use smooth scrolling">
>+<!ENTITY useSmoothScroll.accesskey              "U">
>+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
>+<!ENTITY scrollPgLtPgRt.accesskey        "o">
>+<!ENTITY textsize.label                  "Make the text larger or smaller">
>+<!ENTITY textsize.accesskey              "k">
> <!ENTITY keywordsEnabled.label                 "Enable Internet Keywords">
>+<!ENTITY keywordsEnabled.accesskey             "E">
> <!ENTITY autoCompleteEnabled.label             "Automatically complete text typed into Location bar.">
>+<!ENTITY autoCompleteEnabled.accesskey         "A">
I don't agree with these changes. (Note: "into Location bar" should be "into
the Location bar".)

>+<!ENTITY enablePrefetch.label             "Prefetch web pages when idle, so that links in web pages designed for prefetching can load faster.">
>+<!ENTITY prefTurbo.desc             "If you check this item, part of &brandShortName; will stay in memory when not in use, allowing it to start up faster.">
While you're changing these lines, please change "faster" (adjective) into
"more quickly" (adverb).

I did this review on Linux so I haven't looked at the windows system panel yet.

Comment 16

[[e-mail]]

Comment on attachment 196154 [details] [diff] [review]
Again...

Oh, I see now, those changes are just entity rename/removal.

Comment 17

[Ian Neal]

(In reply to comment #13)
> (From update of attachment 196166 [details] [diff] [review] [edit])
> >Index: locale/en-US/mailPrefsOverlay.dtd
> >===================================================================
> >+<!-- These are added to the Advanced - Scripts & Plug-ins panel -->
> 
> This panel still needs som lovin':
> 1. 'Navigato_r_' --> but 'N' isn't used?!
This is done in the other patch on this bug.

> 2. 'Allow Scripts to' lacks an accesskey (to get the focus into the list)
Probably should be done on the other patch in this bug.

Comment 18

[Ian Neal]

(In reply to comment #15)
> (From update of attachment 196154 [details] [diff] [review] [edit])
> >+<!ENTITY showHideTooltips.label                 "Show Tooltips">
> >+<!ENTITY showHideTooltips.accesskey             "S">
> >+<!ENTITY useSiteIcons.label                     "Show Web Site Icons">
> >+<!ENTITY useSiteIcons.accesskey                 "W">
> >+<!ENTITY useSmoothScroll.label                  "Use smooth scrolling">
> >+<!ENTITY useSmoothScroll.accesskey              "U">
Something really needs to be done about "i" as an accesskey for "Show Web Site
Icons", any alternate suggestions?

> >+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
> >+<!ENTITY scrollPgLtPgRt.accesskey        "o">
That one isn't a change of accesskey, just a whitespace change.

> >+<!ENTITY textsize.label                  "Make the text larger or smaller">
> >+<!ENTITY textsize.accesskey              "k">
> > <!ENTITY keywordsEnabled.label                 "Enable Internet Keywords">
> >+<!ENTITY keywordsEnabled.accesskey             "E">
> > <!ENTITY autoCompleteEnabled.label             "Automatically complete text
typed into Location bar.">
> >+<!ENTITY autoCompleteEnabled.accesskey         "A">
Again accesskey of "l" needs to be changed, any alternate suggestion?

I did notice pref-cache, pref-search and pref-colors all have double spacing
between ENTITY and the entity name itself.

Comment 19

[Giacomo Magnini]

(In reply to comment #18)
> > >+<!ENTITY useSiteIcons.label                     "Show Web Site Icons">
> > >+<!ENTITY useSiteIcons.accesskey                 "W">
> Something really needs to be done about "i" as an accesskey for "Show Web Site
> Icons", any alternate suggestions?

"W" is not ok? Why?

> > >+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
> > >+<!ENTITY scrollPgLtPgRt.accesskey        "o">
> That one isn't a change of accesskey, just a whitespace change.

Used your suggestions in the other bug locally.

> > > <!ENTITY autoCompleteEnabled.label             "Automatically complete text
> typed into Location bar.">
> > >+<!ENTITY autoCompleteEnabled.accesskey         "A">
> Again accesskey of "l" needs to be changed, any alternate suggestion?

Why not "A" as in the patch?

> I did notice pref-cache, pref-search and pref-colors all have double spacing
> between ENTITY and the entity name itself.

Fixed locally.

Comment 20

[[e-mail]]

Comment on attachment 196154 [details] [diff] [review]
Again...

>+<!ENTITY showHideTooltips.label                 "Show Tooltips">
>+<!ENTITY showHideTooltips.accesskey             "S">
>+<!ENTITY useSiteIcons.label                     "Show Web Site Icons">
>+<!ENTITY useSiteIcons.accesskey                 "W">
>+<!ENTITY useSmoothScroll.label                  "Use smooth scrolling">
>+<!ENTITY useSmoothScroll.accesskey              "U">
Ah, I forgot that an "I" isn't visible in a dialog font, but can you make
showHideTooltips T again, and then use S for one of the other two (I don't mind
which but perhaps IanN does)?

>+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
>+<!ENTITY scrollPgLtPgRt.accesskey        "o">
Strange, my diff -w showed this as a change.

> <!ENTITY autoCompleteEnabled.label             "Automatically complete text
typed into Location bar.">
>+<!ENTITY autoCompleteEnabled.accesskey         "A">
A captial L should be fine here, no?

Comment 21

[Giacomo Magnini]

Attachment: Updated patch, hopefully addressing both Neil & Ian suggestions

Comment 22

[Giacomo Magnini]

Attachment: Updated patch for Mnyromyr comments

-w version for easier review:
- fixed also pref-notifications panel caption as suggested
- didn't fix pref-viewing_messages since that is being addressed elsewhere
- reverted Next accesskey to 'x' to avoid collision

Comment 23

[Giacomo Magnini]

Attachment: Unbitrooted after IanN checkin

Comment 24

[Giacomo Magnini]

Attachment: Fixed also the pref-viewing_messages caption, sice IanN's checkin didn't address it.

Comment 25

[Ian Neal]

Comment on attachment 197843 [details] [diff] [review]
Updated patch, hopefully addressing both Neil & Ian suggestions

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-smart_browsing.dtd
>===================================================================
>@@ -5,25 +5,26 @@
> 
> <!--LOCALIZATION NOTE (internetKeywordsHeader.label): DONT_TRANSLATE -->
> <!ENTITY keywordsEnabled.label                 "Enable Internet Keywords">
>-<!ENTITY keywordsEnabled.accesskey             "k">
>+<!ENTITY keywordsEnabled.accesskey             "E">
I think Neil suggested this should stay as "K"

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd
>===================================================================
>@@ -1,32 +1,29 @@
.
.
>+<!ENTITY prefetchTitle.label              "Link Prefetching">
>+<!ENTITY enablePrefetch.label             "Prefetch web pages when idle, so that links in web pages designed for prefetching can load faster.">
Neil wanted "faster" -> "more quickly" here

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-mousewheel.dtd
>===================================================================
>@@ -1,29 +1,29 @@
.
.
>+<!ENTITY scroll.label                    "Scroll the document by ">
>+<!ENTITY scroll.accesskey                "t">
I think Neil suggested this should stay as "S"
.
.
>+<!ENTITY scrollPgLtPgRt.label            "Scroll a page left or a page right">
>+<!ENTITY scrollPgLtPgRt.accesskey        "S">
I think Neil suggested this should stay as "o"
.
.
>+<!ENTITY textsize.label                  "Make the text larger or smaller">
>+<!ENTITY textsize.accesskey              "k">
I think Neil suggested this should stay as "t"

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-advanced.dtd
>===================================================================
>@@ -1,30 +1,24 @@
.
.
>+<!ENTITY enbJavaCheck.label         "Enable Java">
>+<!ENTITY enbJavaCheck.accesskey     "E">
I think Neil suggested this should stay as "J"

Comment 26

[Ian Neal]

Comment on attachment 198014 [details] [diff] [review]
Fixed also the pref-viewing_messages caption, sice IanN's checkin didn't address it.

>Index: locale/en-US/pref-mailnews.dtd
>===================================================================
>@@ -31,37 +31,37 @@
.
.
> <!ENTITY junkMailButton.label             "Junk">
>-<!ENTITY junkMailButton.accesskey         "J">
>+<!ENTITY junkMailButton.accesskey    "u">
Not sure why you are making the change above.

Comment 27

[Giacomo Magnini]

(In reply to comment #25)
> I think Neil suggested this should stay as "K"
> I think Neil suggested this should stay as "o"
> I think Neil suggested this should stay as "t"
> I think Neil suggested this should stay as "J"

Done.

> Neil wanted "faster" -> "more quickly" here

I can swear I actually made this change: anyway, done again.

Comment 28

[Giacomo Magnini]

(In reply to comment #26)
> Not sure why you are making the change above.

Me neither. :)
Fixed locally and waiting for more review comments from Mnyromyr. 

Comment 29

[Giacomo Magnini]

Attachment: Fixed Ian's comments

Not sure if I can carry over Ian r+, so asking again.

Comment 30

[Ian Neal]

Comment on attachment 198134 [details] [diff] [review]
Fixed Ian's comments

>Index: xpfe/components/prefwindow/resources/locale/en-US/pref-smartupdate.dtd
>===================================================================
>@@ -1,22 +1,22 @@
.
.
> <!ENTITY enableNotification.label             "Notify me when new and updated software is available">
> <!ENTITY enableNotification.accesskey         "n">
Should be "N"

> <!ENTITY requireConfirmation.label            "Require manual confirmation of each install">
> <!--LOCALIZATION NOTE (selectUninstall.label): A large list box appears below this label -->
> <!ENTITY selectUninstall.label                "To uninstall, select from the following list and click the uninstall button">
> <!ENTITY uninstallButton.label                "Uninstall">
> <!ENTITY uninstallButton.accesskey            "u">
Should be "U"

r=me with those changes

Comment 31

[Giacomo Magnini]

Attachment: Case fixed.

Comment 32

[[e-mail]]

Comment on attachment 198204 [details] [diff] [review]
Case fixed.

Nit: last three entities in pref-cache.dtd don't line up with the others.

Comment 33

[Giacomo Magnini]

Attachment: Fixed nits, ready for checkin. (Checked in trunk / branch 1.8.1)

Carrying over r/sr flags.

Comment 34

[Ian Neal]

Comment on attachment 198422 [details] [diff] [review]
Fixed nits, ready for checkin. (Checked in trunk / branch 1.8.1)

Checking in
locale/en-US/pref-smart_browsing.dtd;
new revision: 1.32; previous revision: 1.31
locale/en-US/pref-smartupdate.dtd;
new revision: 1.14; previous revision: 1.13
locale/en-US/pref-winhooks.dtd;
new revision: 1.17; previous revision: 1.16
locale/en-US/pref-cache.dtd;
new revision: 1.26; previous revision: 1.25
locale/en-US/pref-download.dtd;
new revision: 1.19; previous revision: 1.18
locale/en-US/pref-applications.dtd;
new revision: 1.16; previous revision: 1.15
locale/en-US/pref-search.dtd;
new revision: 1.22; previous revision: 1.21
locale/en-US/pref-mousewheel.dtd;
new revision: 1.13; previous revision: 1.12
locale/en-US/pref-appearance.dtd;
new revision: 1.22; previous revision: 1.21
locale/en-US/pref-scripts.dtd;
new revision: 1.12; previous revision: 1.11
locale/en-US/pref-colors.dtd;
new revision: 1.25; previous revision: 1.24
locale/en-US/pref-advanced.dtd;
new revision: 1.30; previous revision: 1.29
content/pref-scripts.xul;
new revision: 1.21; previous revision: 1.20
content/pref-applications.xul;
new revision: 1.57; previous revision: 1.56
content/pref-smart_browsing.xul;
new revision: 1.68; previous revision: 1.67
content/pref-winhooks.xul;
new revision: 1.36; previous revision: 1.35
content/pref-advanced.xul;
new revision: 1.90; previous revision: 1.89
done

Comment 35

[Karsten Düsterloh]

Comment on attachment 198014 [details] [diff] [review]
Fixed also the pref-viewing_messages caption, sice IanN's checkin didn't address it.

>Index: locale/en-US/pref-mailnews.dtd
>===================================================================
> <!ENTITY pref.mailnews.title              "Mail &amp; Newsgroups">
>-<!ENTITY generalSettings.label            "General Settings">
>+<!ENTITY generalSettings.caption     "General Settings">

Don't change the indentation.

> <!ENTITY preserveThreading.label          "Preserve threading when sorting messages">
>-<!ENTITY preserveThreading.accesskey      "t">
>+<!ENTITY preserveThreading.accesskey "e">

Why that? The 't' isn't used as an accesskey on that panel, no need to change
it.

> <!ENTITY rememberLastMsg.label            "Remember the last selected message">
>-<!ENTITY rememberLastMsg.accesskey        "e">
>+<!ENTITY rememberLastMsg.accesskey   "R">

We need the 'R' for "make SM the default _R_SS handler" (as soon as that
lands), so this change isn't as appealing as it might look...

> <!ENTITY junkMailButton.label             "Junk">
>-<!ENTITY junkMailButton.accesskey         "J">
>+<!ENTITY junkMailButton.accesskey    "u">

Why that? The 'J' isn't used as an accesskey on that panel, no need to change
it.

>Index: locale/en-US/pref-notifications.dtd
>===================================================================
> <!ENTITY pref.notifications.title         "Notifications">
>+<!ENTITY notifications.caption       "Notifications">

Heed the indentation.


r=me with these (non-)changes.

Comment 36

[Gérard Talbot]

>>-<!ENTITY preserveThreading.accesskey      "t">
>>+<!ENTITY preserveThreading.accesskey "e">
> Why that? The 't' isn't used as an accesskey on that panel, no need to 
> change it.

In my opinion, "t", "f" and "r" are rather narrow letters for an underline, not
easy to find/see unless you're actually seeking for accesskeys.

Comment 37

[Karsten Düsterloh]

> In my opinion, "t", "f" and "r" are rather narrow letters for an underline, not
> easy to find/see unless you're actually seeking for accesskeys.

Mmh, okay, and that is even more true for i, j, l etc.
We usuallly try to use, though, either the first letter of the first (here: P of
'Preserve', but already used by Print) or most relevant (here: t of 'threading')
word of the label for the accesskey, so on second thought, I'm not actually sure
anymore if it is a /bad/ change - but I'm also not sure it is a /good/ one.
I'm fine either way now, though (for this specific key).

Comment 38

[Giacomo Magnini]

Attachment: What Mnyromyr said.

Left "R" as a free accesskey for future use. Used "v" for "Preserve".

Comment 39

[Giacomo Magnini]

Comment on attachment 199060 [details] [diff] [review]
What Mnyromyr said. 

Sorry for bug spam, wrong patch.

Comment 40

[Giacomo Magnini]

Attachment: What Mnyromyr said, take 2.

Comment 41

[[e-mail]]

Comment on attachment 199061 [details] [diff] [review]
What Mnyromyr said, take 2.

>-        <checkbox id="mailnewsStartPageEnabled" label="&enableStartPage.label;"
>+        <checkbox id="mailnewsStartPageEnabled" label="&enableStartPage.caption;"
This isn't a <caption>, please revert this change. sr=me with this fixed.

>+    <caption label="&notifications.caption;"/>
> 
>+    <label value="&newMessagesArrive.label;"/>
What was the point of this? I can only see that you wouldn't want the trailing
: in the caption. Mnyromyr, what would you prefer?

Comment 42

[Karsten Düsterloh]

> >+    <caption label="&notifications.caption;"/>
> >+    <label value="&newMessagesArrive.label;"/>
> What was the point of this?
> I can only see that you wouldn't want the trailing
> : in the caption. Mnyromyr, what would you prefer?

See the latter part of my comment #13, which Giacomo implemented.

 

Comment 43

[Giacomo Magnini]

Attachment: Patch ready for checkin (checked in trunk / branch 1.8.1)

Reverted change as asked by Neil, and left the other change as is, as Mnyromyr
explained the idea. Carrying over r/sr flags.

Comment 44

[Mark Banner (:standard8)]

Comment on attachment 199431 [details] [diff] [review]
Patch ready for checkin (checked in trunk / branch 1.8.1)

This patch now checked in:
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-mailnews.xul,v  <--
 pref-mailnews.xul
new revision: 1.80; previous revision: 1.79
done
Checking in mailnews/base/prefs/resources/content/pref-notifications.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-notifications.xul,v
 <--  pref-notifications.xul
new revision: 1.11; previous revision: 1.10
done
Checking in mailnews/base/prefs/resources/content/pref-receipts.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-receipts.xul,v  <--
 pref-receipts.xul
new revision: 1.37; previous revision: 1.36
done
Checking in mailnews/base/prefs/resources/content/pref-viewing_messages.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-viewing_messages.xu
l,v  <--  pref-viewing_messages.xul
new revision: 1.50; previous revision: 1.49
done
Checking in mailnews/base/prefs/resources/locale/en-US/mailPrefsOverlay.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/mailPrefsOverlay.dt
d,v  <--  mailPrefsOverlay.dtd
new revision: 1.23; previous revision: 1.22
done
Checking in mailnews/base/prefs/resources/locale/en-US/pref-mailnews.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-mailnews.dtd,v
 <--  pref-mailnews.dtd
new revision: 1.36; previous revision: 1.35
done
Checking in mailnews/base/prefs/resources/locale/en-US/pref-notifications.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-notifications.
dtd,v  <--  pref-notifications.dtd
new revision: 1.7; previous revision: 1.6
done
Checking in mailnews/base/prefs/resources/locale/en-US/pref-receipts.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-receipts.dtd,v
 <--  pref-receipts.dtd
new revision: 1.14; previous revision: 1.13
done
Checking in
mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-viewing_messag
es.dtd,v  <--  pref-viewing_messages.dtd
new revision: 1.26; previous revision: 1.25

Comment 45

[Ian Neal]

Comment on attachment 198422 [details] [diff] [review]
Fixed nits, ready for checkin. (Checked in trunk / branch 1.8.1)

Requesting a= for SM1.1a for this polish/accessibility patch

Comment 46

[Ian Neal]

Comment on attachment 199431 [details] [diff] [review]
Patch ready for checkin (checked in trunk / branch 1.8.1)

Requesting a= for SM1.1a for this polish/accessibility patch

Comment 47

[Robert Kaiser]

Comment on attachment 198422 [details] [diff] [review]
Fixed nits, ready for checkin. (Checked in trunk / branch 1.8.1)

a=me for SeaMonkey 1.1

Comment 48

[Robert Kaiser]

Comment on attachment 199431 [details] [diff] [review]
Patch ready for checkin (checked in trunk / branch 1.8.1)

a=me for SeaMonkey 1.1

Comment 49

[Ian Neal]

Comment on attachment 198422 [details] [diff] [review]
Fixed nits, ready for checkin. (Checked in trunk / branch 1.8.1)

Checking in (branch 1.8.1)
locale/en-US/pref-smart_browsing.dtd;
new revision: 1.31.6.2; previous revision: 1.31.6.1
locale/en-US/pref-smartupdate.dtd;
new revision: 1.13.6.2; previous revision: 1.13.6.1
locale/en-US/pref-winhooks.dtd;
new revision: 1.15.6.2; previous revision: 1.15.6.1
locale/en-US/pref-cache.dtd;
new revision: 1.25.6.1; previous revision: 1.25
locale/en-US/pref-download.dtd;
new revision: 1.18.6.1; previous revision: 1.18
locale/en-US/pref-applications.dtd;
new revision: 1.15.6.1; previous revision: 1.15
locale/en-US/pref-search.dtd;
new revision: 1.21.6.2; previous revision: 1.21.6.1
locale/en-US/pref-mousewheel.dtd;
new revision: 1.12.6.1; previous revision: 1.12
locale/en-US/pref-appearance.dtd;
new revision: 1.21.6.1; previous revision: 1.21
locale/en-US/pref-scripts.dtd;
new revision: 1.11.6.1; previous revision: 1.11
locale/en-US/pref-colors.dtd;
new revision: 1.24.6.1; previous revision: 1.24
locale/en-US/pref-advanced.dtd;
new revision: 1.29.6.1; previous revision: 1.29
content/pref-scripts.xul;
new revision: 1.20.6.1; previous revision: 1.20
content/pref-applications.xul;
new revision: 1.56.6.1; previous revision: 1.56
content/pref-smart_browsing.xul;
new revision: 1.67.6.1; previous revision: 1.67
content/pref-winhooks.xul;
new revision: 1.34.6.2; previous revision: 1.34.6.1
content/pref-advanced.xul;
new revision: 1.89.6.1; previous revision: 1.89
done

Comment 50

[Ian Neal]

Comment on attachment 199431 [details] [diff] [review]
Patch ready for checkin (checked in trunk / branch 1.8.1)

Checking in (branch 1.8.1)
content/pref-mailnews.xul;
new revision: 1.78.4.2; previous revision: 1.78.4.1
content/pref-notifications.xul;
new revision: 1.9.22.2; previous revision: 1.9.22.1
content/pref-receipts.xul;
new revision: 1.35.26.2; previous revision: 1.35.26.1
content/pref-viewing_messages.xul;
new revision: 1.47.6.3; previous revision: 1.47.6.2
locale/en-US/mailPrefsOverlay.dtd;
new revision: 1.20.6.3; previous revision: 1.20.6.2
locale/en-US/pref-mailnews.dtd;
new revision: 1.34.4.2; previous revision: 1.34.4.1
locale/en-US/pref-notifications.dtd;
new revision: 1.5.28.2; previous revision: 1.5.28.1
locale/en-US/pref-receipts.dtd;
new revision: 1.12.28.2; previous revision: 1.12.28.1
locale/en-US/pref-viewing_messages.dtd;
new revision: 1.23.6.3; previous revision: 1.23.6.2
done