302499 - change context for at attribute on insert

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

Per errata E27, we need to evaluate the at attribute with the context node and
size of the node set binding.

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[Allan Beaufour]

Attachment: Patch

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 191211 [details] [diff] [review]
Patch


>+
>+  if (isnan(atDoub))
>+    return NS_OK;

Why this?

Insert Element:
"If the result is NaN, the insert appends to the end of the node-set."

Comment 4

[Allan Beaufour]

(In reply to comment #3)
> (From update of attachment 191211 [details] [diff] [review] [edit])
> 
> >+
> >+  if (isnan(atDoub))
> >+    return NS_OK;
> 
> Why this?
> 
> Insert Element:
> "If the result is NaN, the insert appends to the end of the node-set."

Lesson to myself: Do not make code while having a hangover.

Comment 5

[Allan Beaufour]

Attachment: Patch without isnan()

Here's a patch without isnan() which was used in the wrong way per the spec.
and which is not portable. I'll create another bug for that, ok?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 191330 [details] [diff] [review]
Patch without isnan()

I think this is ok for now.

Comment 7

[Doron Rosenberg (IBM)]

checked in.

Comment 8

[Allan Beaufour]

(In reply to comment #5)
> Created an attachment (id=191330) [edit]
> Patch without isnan()
> 
> Here's a patch without isnan() which was used in the wrong way per the spec.
> and which is not portable. I'll create another bug for that, ok?

Created bug 303198 for that.