302548 - planet.mozilla.org RSS 2.0 feed has bad guids

Status: RESOLVED FIXED

(Websites :: planet.mozilla.org, defect)

Description

[Phil Ringnalda (:philor)]

The RSS 2.0 <guid> element has a default of 'true' for the isPermaLink
attribute, so Firefox (among many others) will treat <guid>foo</guid> as the
link for an item (see bug 260918). Because the default Planet Planet
rss20.xml.tmpl incorrectly uses <guid><TMPL_VAR id ESCAPE="HTML"></guid> rather
than <guid isPermaLink="false"><TMPL_VAR id ESCAPE="HTML"></guid>, when the id
for an item comes from somewhere that isn't a permalink (e.g., the tag: URIs in
MozillaZine's Atom feed <id>s), clients wind up linking to a tag: URI rather
than falling back to the correct URL in the <link>.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Forumzilla sees these tag URIs as links too, and when it normalizes them via
nsIStandardURL, a URI like tag:mozillazine.org,2004:article7250 gets converted
into tag://mozillazine.org,2004/.  Since that conversion drops the unique story
identifier (article7250 in the URI above), Forumzilla decides it has seen that
story already and doesn't download it.  Thunderbird's feed reader, which is
based on Forumzilla, may have the same problem.

Who is responsible for planet these days?

Comment 2

[tor]

I've done the isPermaLink="false" change.  Let me know if that fixes things for you.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

It sure does; thanks Tor!

Comment 4

[Reed Loden [:reed]]

--> Websites :: planet.mozilla.org

Comment 5

[Phil Ringnalda (:philor)]

Sheesh, I was going there, before you midaired me.

It did do the trick, until it got reverted by something. Now we're back to <guid>tag:...

Comment 6

[tor]

Fix in, pending push to the server (bug 356311).

Comment 7

[Phil Ringnalda (:philor)]

Re-fixed (several days back, when I meant to re-close), thanks!