302582 - "add component/version" doesn't include action=add on enter_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

When trying to enter a bug into a product which has no component, we
get:

Sorry, the product xxxxxx has to have at least one component in order for
you to enter a bug into it.

Create a new component. 


But the link "Create a new component" brings you to
editcomponents.cgi?product=sans_comp

instead of
editcomponents.cgi?action=add&product=sans_comp


We already know there is no componement for this product, so the first link is
useless; we should directly go to the last one, i.e. with action=add.

The same comment applies to a missing version.

Comment 1

[Emmanuel Seyman]

Attachment: Patch to go directly to the "add" page

Comment 2

[Emmanuel Seyman]

Comment on attachment 190931 [details] [diff] [review]
Patch to go directly to the "add" page

Man, I need coffee. Asking for review

Comment 3

[Frédéric Buclin]

Comment on attachment 190931 [details] [diff] [review]
Patch to go directly to the "add" page

>-      <a href="editcomponents.cgi?product=[% product FILTER url_quote %]">Create
>+      <a href="editcomponents.cgi?action=add&product=[% product FILTER url_quote %]">Create

>-      <a href="editversions.cgi?product=[% product FILTER url_quote %]">Create
>+      <a href="editversions.cgi?action=add&product=[% product FILTER url_quote %]">Create

ampersands must be escaped &amp;

Comment 4

[Emmanuel Seyman]

Attachment: Taking into account LpSolit's review

Comment 5

[Frédéric Buclin]

Comment on attachment 190935 [details] [diff] [review]
Taking into account LpSolit's review

r=LpSolit

Comment 6

[Frédéric Buclin]

tip:

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.119; previous revision: 1.118
done


2.20rc1:

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.115.2.3; previous revision: 1.115.2.2
done