Closed Bug 302624 Opened 19 years ago Closed 19 years ago

"Delete from pop server" Filter Action Doesn't Work on filters run after the fact

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sasafrass452, Assigned: Bienvenu)

Details

Attachments

(1 file)

proposed fix
3.90 KB, patch
mscott
: superreview+
mscott
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050718 Firefox/1.0.5 (Debian package 1.0.5-0.0.0.50.linspire0.1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050718 Firefox/1.0.5 (Debian package 1.0.5-0.0.0.50.linspire0.1)

As stated above, the "Delete from POP server" filter action doesn't work.
Messages are not deleted even though the option was selected. I've tried
different email accounts with the same result, so this is obviously a bug that
must be fixed.

Reproducible: Always

Steps to Reproduce:
1. Create filter
2. Choose sender isn't in addressbook
3. Choose Delete from POP server

Actual Results:  
Messages that should be deleted are downloaded to the inbox.

Expected Results:  
Messages should be deleted from the pop server.
Version: unspecified → 1.0
this works fine for me - but I think you're equating deleting from the pop3
server with *not* downloading the message at all. That's not the way it works.
We'll still download the message. For some messages, I want to download them,
but delete them from the server at the same time. We have no filter action for
"delete from server and don't download". Perhaps you could turn this into an RFE. 
No, that's not what I'm talking about. Read my bug report again ;)

(In reply to comment #1)
> this works fine for me - but I think you're equating deleting from the pop3
> server with *not* downloading the message at all. That's not the way it works.
> We'll still download the message. For some messages, I want to download them,
> but delete them from the server at the same time. We have no filter action for
> "delete from server and don't download". Perhaps you could turn this into an RFE. 
You said this:

>Actual result:
>"Messages that should be deleted are downloaded to the inbox."

This implied to me that you don't want them to be downloaded to the inbox.

That actual result is to be expected. We download the message, and then delete
it from the server the next time you get new mail.



No, you misunderstood. I'm talking about the FILTER, as in preventing spam from
reaching my inbox. I want to delete messages from senders that are NOT in my
address book to avoid spam. This worked when I was using windows2k. I'm now
using Linux. When messages are being downloaded, the spam should be deleted from
the server. But that's not the case here.

(In reply to comment #3)
> You said this:
> 
> >Actual result:
> >"Messages that should be deleted are downloaded to the inbox."
> 
> This implied to me that you don't want them to be downloaded to the inbox.
> 
> That actual result is to be expected. We download the message, and then delete
> it from the server the next time you get new mail.
> 
> 
> 

Can you attach or e-mail me a pop3 protocol log by following the instructions
below, substituting POP3 for protocol? The log should be of a session where you
get mail that the filter should have deleted from the server, *and* you do a
subsequent get new mail after that which will cause the delete to happen on the
server.

This filter is run when mail is downloaded, not after the fact, with the "apply
this filter" command, correct?

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html
If I have a log file, I don't know where it is. The website you directed me to
had nothing to do with a log file for receiving mail on Linux systems.

Trust me on this. I know what I'm talking about, & it's an obvious bug. That's
why I sent this report.

The emails I've received for the replies here would've been deleted from the
server, because the email address is not in my address book. I currently have
the filter set to move messages to the trash, because "delete from pop server"
doesn't work. Otherwise, I wouldn't be getting the replies here.

(In reply to comment #5)
> 
> Can you attach or e-mail me a pop3 protocol log by following the instructions
> below, substituting POP3 for protocol? The log should be of a session where you
> get mail that the filter should have deleted from the server, *and* you do a
> subsequent get new mail after that which will cause the delete to happen on the
> server.
> 
> This filter is run when mail is downloaded, not after the fact, with the "apply
> this filter" command, correct?
> 
> http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html


there's a link at the very top of that page that takes you to the instructions
for a pop3 protocol log -
http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#pop


Ok, I turned on the filter log, & this is what it says:

Applied filter "Untitled Filter" to message from bugzilla-daemon@mozilla.org -
[Bug 302624] "Delete from pop server" Filter Action Doesn't Work at 2005-07-29
12:49:08 Action = Delete from Pop3 server 


Applied filter "Untitled Filter" to message from - at 1969-12-31 19:00:00 Action
= Move to folder mailbox://Sasafrass452%40yahoo.com@localhost/Trash id =

The first one should've been deleted outright, but it went to my inbox instead.


>The first one should've been deleted outright, but it went to my inbox instead.

I'm really sorry, but we seem to be going in circles. The delete from server
filter action doesn't prevent a message from getting downloaded to the inbox. It
has nothing to do with whether a message gets downloaded to the inbox - it just
causes the message to get deleted from the pop3 server *after* downloading it to
the inbox. Your second filter that moves the message to the trash should have
prevented the message from ending up in the inbox, but if that's the problem, it
would be the move to folder filter action that's broken for you, not the delete
from pop server filter action. Does that make any sense?
When I was using Windows 2000, I had the filter set to "delete from pop server",
& I NEVER saw any messages that were not from senders in my address book. Those
messages were deleted. That doesn't happen now on my Linux system.

The filter log I posted shows 2 seperate messages. If what you say is correct,
than that filter option was changed to work differently, which is doubtful. I'll
tell you what... I can test it on a windows machine & confirm what I've been
saying. Then I'll come back here & let you know.

(In reply to comment #9)
> >The first one should've been deleted outright, but it went to my inbox instead.
> 
> I'm really sorry, but we seem to be going in circles. The delete from server
> filter action doesn't prevent a message from getting downloaded to the inbox. It
> has nothing to do with whether a message gets downloaded to the inbox - it just
> causes the message to get deleted from the pop3 server *after* downloading it to
> the inbox. Your second filter that moves the message to the trash should have
> prevented the message from ending up in the inbox, but if that's the problem, it
> would be the move to folder filter action that's broken for you, not the delete
> from pop server filter action. Does that make any sense?


>If what you say is correct,than that filter option was changed to work
>differently, which is doubtful.

I wrote and maintain that code, and the intended (and afaik, actual) behaviour
has always been what I described.  I wonder if you had two filters that were
firing on the other system, one to delete from server, and one to move to trash,
and thus the messages never showed up in your inbox.
Nope, I only had "delete from pop server" checked & I never saw the deleted
messages, not even in the trash.

(In reply to comment #11)
> >If what you say is correct,than that filter option was changed to work
> >differently, which is doubtful.
> 
> I wrote and maintain that code, and the intended (and afaik, actual) behaviour
> has always been what I described.  I wonder if you had two filters that were
> firing on the other system, one to delete from server, and one to move to trash,
> and thus the messages never showed up in your inbox.


>Nope, I only had "delete from pop server" checked & I never saw the deleted
>messages, not even in the trash.

OK, thx, I'll take your word for it. That would be a horrible dataloss bug for
most people. Luckily for you it was desired behaviour :-) If you can reproduce
that, I'd really like to know about it. For now, I think I'm going to mark this
bug Works for Me, since now it's really working the way it was intended...
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
Well, I tested it on a windows machine, & it does NOT delete the messages as I
expected. So, I guess you were right. By any chance, did TB version 1.0.4 work
the way I described? I believe that's the last version I used on windows, which
was back in february when I switched to Linux.

(In reply to comment #13)
> OK, thx, I'll take your word for it. That would be a horrible dataloss bug for
> most people. Luckily for you it was desired behaviour :-) If you can reproduce
> that, I'd really like to know about it. For now, I think I'm going to mark this
> bug Works for Me, since now it's really working the way it was intended...


no version, afaik, has worked the way you describe. As I said before, that would
be a dataloss bug, according to the intent of that feature.
Ok, then.... Thanx for clearing this up for me, I truly thought it was a bug
when it was apparently a problem with my windows machine. No wonder I switched
to linux :P

(In reply to comment #15)
> no version, afaik, has worked the way you describe. As I said before, that would
> be a dataloss bug, according to the intent of that feature.


David - I do understand what "Delete from POP server" means - and it doesn't
work for me.

I've got a filter rule set: "If Status is Flagged -> Delete Message & Delete
From POP Server". I perform these actions:

1. check my account;
2. manually flag one e-mail I want to delete;
3. run filters on folder;
4. -> the e-mail is moved to Trash (OK);
5. close and open TB;
6. check my account again;
7. open FF;
8. log into my account (using webmail);
9. find the email in question in my Inbox (NOT the TB Inbox - the webmail Inbox)
- apparently it has NOT been deleted from the POP server.
10. the Filter Log says both filters have been applied...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050804
Thunderbird/1.0+ ID:2005080406
the delete from server filter action doesn't work on filters that run after the
fact,e.g., from run filters on folder. Do you have tbird set to delete messages
from server when deleted locally? I assume not or they would still get deleted
from the server in your scenario. I've re-opened this and changed the summary...
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
Summary: "Delete from pop server" Filter Action Doesn't Work → "Delete from pop server" Filter Action Doesn't Work on filters run after the fact
Thanks for clarifying. Your assumption is correct - all I want to do is to be
able to set MANUALLY which e-mails I want to get deleted from the POP server
(which is why I flag them first) - am I right it is not possible now?
Attached patch proposed fix — — Splinter Review 
the nsMsgWindow.cpp change was needed because the filters msg window doesn't
have a command object, and we attempt to reload the loaded message from that
window, after downloaded the msg body.
Assignee: mscott → bienvenu
Status: UNCONFIRMED → ASSIGNED
Attachment #192226 - Flags: superreview?(mscott)
Attachment #192226 - Flags: superreview?(mscott)
Attachment #192226 - Flags: superreview+
Attachment #192226 - Flags: approval1.8b4+
fixed - bear in mind that delete from server won't actually happen until the
next time we get new messages...
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
How do I apply this fix? Will it work on Linux? Or will the next version of
Thunderbird resolve it?
the next nightly build, or next *major version* will have the fix (1.5) . A 1.0x
version will *not* have the fix.
Thanks a lot, David - works great :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: